From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F155C433F5 for ; Wed, 25 May 2022 12:01:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242540AbiEYMBx (ORCPT ); Wed, 25 May 2022 08:01:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230375AbiEYMBt (ORCPT ); Wed, 25 May 2022 08:01:49 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EA30FDD; Wed, 25 May 2022 05:01:48 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 22D861F44D7A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1653480101; bh=F1F4jhbrNEQ3CCy7KGKBR+is9F4rhkQOEU0CQ1t/4vI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZaUKr/IggQ5jzu5IdAvmbRfj072K4RQwepDOrvHjQ9MwkmtGkxO2gtj7YfrKtV3HO qnfdRjJwuNxI+0Ir0hKlxSvSwCtBIawpDNThcWifoltYpNGG8lse1rhjNeCDFNoM3V Xl9tx06OUvZMtWhT8Y5uvNWkRKwBZ1gKHqayBiXuDAmwEq7G+2rZJI/opM1w4EPHma XMOImZk4iTV/PPRbpu6WyQdtbYTK1Odd4W0DoCFgUuIL2tLd+rqpeSwKMgPD1hbSPc GP6tLFP7Q01XExVCL8+bMWopFkWugUCveMrA3G2fkldDmceunmU97OQMpn4gfuSuMY ibmA0HdwzZW1Q== Message-ID: <4c19d5fb-1e45-9149-4208-5d848eeb7565@collabora.com> Date: Wed, 25 May 2022 14:01:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v10 03/21] drm/edid: Convert cea_sad helper struct to kernelDoc Content-Language: en-US To: Guillaume Ranquet , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Matthias Brugger , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Helge Deller , CK Hu , Jitao shi Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-fbdev@vger.kernel.org References: <20220523104758.29531-1-granquet@baylibre.com> <20220523104758.29531-4-granquet@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220523104758.29531-4-granquet@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 23/05/22 12:47, Guillaume Ranquet ha scritto: > Signed-off-by: Guillaume Ranquet > --- > include/drm/drm_edid.h | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > index 144c495b99c4..37c420423625 100644 > --- a/include/drm/drm_edid.h > +++ b/include/drm/drm_edid.h > @@ -359,12 +359,18 @@ struct edid { > > #define EDID_PRODUCT_ID(e) ((e)->prod_code[0] | ((e)->prod_code[1] << 8)) > > -/* Short Audio Descriptor */ > +/** > + * struct cea_sad - Short Audio Descriptor. Perhaps.... * struct cea_sad - CEA Short Audio Descriptor ...but that's relative to personal liking and nothing else, it's also fine as it is, if you like it more as it is. The ball is yours :-P Regardless of any choice about changing the description or not: Reviewed-by: AngeloGioacchino Del Regno Cheers, Angelo > + * @format: See HDMI_AUDIO_CODING_TYPE_*. > + * @channels: max number of channels - 1. > + * @freq: See CEA_SAD_FREQ_*. > + * @byte2: meaning depends on format. > + */ > struct cea_sad { > u8 format; > - u8 channels; /* max number of channels - 1 */ > + u8 channels; > u8 freq; > - u8 byte2; /* meaning depends on format */ > + u8 byte2; > }; > > struct drm_encoder;