From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch,
robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alistair@alistair23.me,
samuel@sholland.org, josua.mayer@jm0.eu,
letux-kernel@openphoenux.org
Subject: Re: [RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC
Date: Thu, 17 Feb 2022 12:43:32 +0100 [thread overview]
Message-ID: <4c1c1a36-2e6f-a061-5c2b-f2aac31b2d0e@canonical.com> (raw)
In-Reply-To: <20220217123112.3ba70000@aktux>
On 17/02/2022 12:31, Andreas Kemnade wrote:
> On Thu, 17 Feb 2022 10:21:15 +0100
> Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote:
>
>> On 06/02/2022 09:00, Andreas Kemnade wrote:
>>> Add a binding for the Electrophoretic Display Controller found at least
>>> in the i.MX6.
>>> The timing subnode is directly here to avoid having display parameters
>>> spread all over the plate.
>>>
>>> Supplies are organized the same way as in the fbdev driver in the
>>> NXP/Freescale kernel forks. The regulators used for that purpose,
>>> like the TPS65185, the SY7636A and MAX17135 have typically a single bit to
>>> start a bunch of regulators of higher or negative voltage with a
>>> well-defined timing. VCOM can be handled separately, but can also be
>>> incorporated into that single bit.
>>>
>>> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
>>> ---
>>> .../bindings/display/imx/fsl,mxc-epdc.yaml | 159 ++++++++++++++++++
>>> 1 file changed, 159 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml
>>>
> [..]
>
>>> +
>>> + DISPLAY-supply:
>>> + description:
>>> + A couple of +/- voltages automatically powered on in a defintive order
>>
>> Typo, definitive?
>>
> yes, of course.
>
>>> +
>>> + VCOM-supply:
>>> + description: compensation voltage
>>> +
>>> + V3P3-supply:
>>
>> All of supplies names - lowercase.
>>
>>> + description: V3P3 supply
>>> +
>>> + epd-thermal-zone:
>>> + description:
>>> + Zone to get temperature of the EPD from, practically ambient temperature.
>>
>> Is it a phandle?
>>
> a string used in
> of_property_read_string(priv->drm.dev->of_node,
> "epd-thermal-zone", &thermal);
> if (thermal) {
> priv->thermal = thermal_zone_get_zone_by_name(thermal);
> if (IS_ERR(priv->thermal))
> return dev_err_probe(priv->drm.dev, PTR_ERR(priv->thermal),
> "unable to get thermal");
> }
OK, then:
$ref: /schemas/types.yaml#/definitions/string
>
> [...]
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/clock/imx6sl-clock.h>
>>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> +
>>> + epdc: epdc@20f4000 {
>>
>> Generic node name, e.g. display-controller
>>
> hmm, does IHMO not make too much sense here. E.g. in the imx6sll.dtsi
> we have lcd-controller next to it. So having epd-controller? But that
> is exactly what epdc stands for.
Still we have "lcd-controller", not "lcdc". Since this is only for epd,
then "epd-controller" seems reasonable. The same as we use
"interrupt-controller" (not "ic"), "dma-controller" (not "dmac" or "dc")
and so on. See also list of recommended generic names from DT specification.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-02-17 11:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 8:00 [RFC PATCH 0/6] drm: EPDC driver for i.MX6 Andreas Kemnade
2022-02-06 8:00 ` [RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC Andreas Kemnade
2022-02-11 15:46 ` Rob Herring
2022-02-14 22:45 ` Andreas Kemnade
2022-02-16 23:52 ` Rob Herring
2022-02-17 9:21 ` Krzysztof Kozlowski
2022-02-17 11:31 ` Andreas Kemnade
2022-02-17 11:43 ` Krzysztof Kozlowski [this message]
2022-03-12 19:23 ` Jonathan Neuschäfer
2022-03-14 22:04 ` Andreas Kemnade
2022-02-06 8:00 ` [RFC PATCH 2/6] drm: Add skeleton for EPDC driver Andreas Kemnade
2022-03-12 19:41 ` Jonathan Neuschäfer
2022-02-06 8:00 ` [RFC PATCH 3/6] drm: mxc-epdc: Add display and waveform initialisation Andreas Kemnade
2022-03-12 20:12 ` Jonathan Neuschäfer
2022-02-06 8:00 ` [RFC PATCH 4/6] drm: mxc-epdc: Add update management Andreas Kemnade
2022-03-12 20:21 ` Jonathan Neuschäfer
2022-02-06 8:00 ` [RFC PATCH 5/6] ARM: dts: imx6sll: add EPDC Andreas Kemnade
2022-02-06 8:00 ` [RFC PATCH 6/6] arm: dts: imx6sl: Add EPDC Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c1c1a36-2e6f-a061-5c2b-f2aac31b2d0e@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=airlied@linux.ie \
--cc=alistair@alistair23.me \
--cc=andreas@kemnade.info \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=josua.mayer@jm0.eu \
--cc=kernel@pengutronix.de \
--cc=letux-kernel@openphoenux.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=shawnguo@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).