From: William Qiu <william.qiu@starfivetech.com>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-mmc@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v1 2/3] mmc: starfive: Add sdio/emmc driver support
Date: Tue, 13 Dec 2022 15:38:16 +0800 [thread overview]
Message-ID: <4c2ae045-9ece-3245-7203-2db21f604ac8@starfivetech.com> (raw)
In-Reply-To: <cd4639e4-b0e4-3141-5b9f-1a7bd14cb799@rock-chips.com>
On 2022/12/13 15:33, Shawn Lin wrote:
> Hi
>
> On 2022/12/13 15:21, William Qiu wrote:
>>
>>
>> On 2022/12/13 10:24, Shawn Lin wrote:
>>> Hi
>>
>>> use ".common_caps = MMC_CAP_CMD23" instead.
>>>
>>
>> Hi Shawn,
>>
>> Thank you for taking time to review.
>> The .common_caps is not defined in dw_mci_drv_data.
>> And .num_caps is also used in dw_mci-rockchip.c.
>>
>
> That means your patch is based on old upstream kernel which hasn't
> been updated for at least one year.:)
>
Sorry about that. I just check the code on 5.15.
I will update it in next version.
Thank you any way.
>> Best regards,
>> William Qiu
>>>> + .set_ios = dw_mci_starfive_set_ios,
>>>> + .parse_dt = dw_mci_starfive_parse_dt,
>>>> + .execute_tuning = dw_mci_starfive_execute_tuning,
>>>> +};
>>>> +
>>>> +static const struct of_device_id dw_mci_starfive_match[] = {
>>>
next prev parent reply other threads:[~2022-12-13 7:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 13:17 [PATCH v1 0/3] StarFive's SDIO/eMMC driver support William Qiu
2022-12-07 13:17 ` [PATCH v1 1/3] dt-bindings: mmc: Add bindings for StarFive William Qiu
2022-12-07 14:19 ` Rob Herring
2022-12-07 14:46 ` Conor Dooley
2022-12-08 8:38 ` William Qiu
2022-12-08 8:34 ` William Qiu
2022-12-07 15:13 ` Krzysztof Kozlowski
2022-12-08 8:44 ` William Qiu
2022-12-08 9:01 ` Krzysztof Kozlowski
2022-12-08 10:02 ` William Qiu
2022-12-08 21:13 ` Linus Walleij
2022-12-09 11:18 ` William Qiu
2022-12-07 13:17 ` [PATCH v1 2/3] mmc: starfive: Add sdio/emmc driver support William Qiu
2022-12-08 21:09 ` Linus Walleij
2022-12-09 11:26 ` William Qiu
2023-02-02 11:09 ` William Qiu
2023-02-02 12:51 ` Linus Walleij
2022-12-13 2:24 ` Shawn Lin
2022-12-13 7:21 ` William Qiu
2022-12-13 7:33 ` Shawn Lin
2022-12-13 7:38 ` William Qiu [this message]
2022-12-07 13:17 ` [PATCH v1 3/3] riscv: dts: starfive: Add mmc node William Qiu
2022-12-07 15:14 ` Krzysztof Kozlowski
2022-12-07 16:31 ` Conor Dooley
2022-12-08 9:57 ` William Qiu
2022-12-08 9:46 ` William Qiu
2022-12-08 21:15 ` Linus Walleij
2022-12-09 11:31 ` William Qiu
2023-01-16 10:13 ` William Qiu
2022-12-16 2:02 ` [PATCH v1 0/3] StarFive's SDIO/eMMC driver support William Qiu
2022-12-16 9:22 ` Ulf Hansson
2022-12-16 9:26 ` William Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c2ae045-9ece-3245-7203-2db21f604ac8@starfivetech.com \
--to=william.qiu@starfivetech.com \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).