From: Guenter Roeck <linux@roeck-us.net>
To: Stefan Wahren <stefan.wahren@i2se.com>,
Alistair Francis <alistair@alistair23.me>,
linux-kernel@vger.kernel.org, shawnguo@kernel.org,
wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org
Cc: linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com,
devicetree@vger.kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH 1/2] watchdog: imx2_wdg: Alow ping on suspend
Date: Thu, 13 Jan 2022 11:43:07 -0800 [thread overview]
Message-ID: <4c3056df-2ae6-04d7-30cb-cd478f089266@roeck-us.net> (raw)
In-Reply-To: <4c5df296-b930-f65f-1106-c00889f1cdc1@i2se.com>
On 1/13/22 10:55 AM, Stefan Wahren wrote:
> Hi,
>
> Am 09.01.22 um 12:41 schrieb Alistair Francis:
>> The i.MX watchdog cannot be disabled by softwrae once it has been
> s/softwrae/software/
>> enabled. This means that it can't be stopped before suspend.
>>
>> For systems that enter low power mode this is fine, as the watchdog will
>> be automatically stopped by hardwrae in low power mode. Not all i.MX
> s/hardwrae/hardware/
>> platforms support low power mode in the mainline kernel. For example the
>> i.MX7D does not enter low power mode and so will be rebooted 2 minutes
>> after entering freeze or mem sleep states.
>>
>> This patch introduces a device tree property "fsl,ping-during-suspend"
>> that can be used to enable ping on suspend support for these systems.
>
> Introducing vendor specific properties for Linux behavior should be
> avoided. The DT should describe just the hardware.
>
> In case i.mx7d is affected, how about enabling this workaround for
> compatible fsl,imx7d-wdt? This has the advantage that in case low power
> mode will be implemented
> <https://elixir.bootlin.com/linux/latest/B/ident/fsl%2Cimx7d-wdt>, we
> don't have to care about DTB files.
>
Agreed.
Guenter
next prev parent reply other threads:[~2022-01-13 19:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 11:41 [PATCH 0/2] watchdog: imx_wdt2: Enable ping on suspend support Alistair Francis
2022-01-09 11:41 ` [PATCH 1/2] watchdog: imx2_wdg: Alow ping on suspend Alistair Francis
2022-01-13 18:55 ` Stefan Wahren
2022-01-13 19:43 ` Guenter Roeck [this message]
2022-01-09 11:41 ` [PATCH 2/2] ARM: dts: imx7d: remarkable2: set ping-during-suspend for watchdog Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c3056df-2ae6-04d7-30cb-cd478f089266@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alistair@alistair23.me \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan.wahren@i2se.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).