From: Markus Elfring <Markus.Elfring@web.de>
To: Wu Bo <wubo40@huawei.com>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Feilong Lin <linfeilong@huawei.com>, Jens Axboe <axboe@kernel.dk>,
Tejun Heo <tj@kernel.org>,
Zhiqiang Liu <liuzhiqiang26@huawei.com>
Subject: Re: [PATCH] blkcg: Fix memory leak in blkg_conf_prep()
Date: Fri, 15 May 2020 17:08:24 +0200 [thread overview]
Message-ID: <4c670a6c-98c3-2b14-7438-09199506d92f@web.de> (raw)
…
> new_blkg = blkg_alloc(pos, q, GFP_KERNEL);
…
I suggest to omit the source code quotation from the change description.
> if calling blkg_lookup_check() failed, at the IS_ERR block,
> the new_blkg should be free before goto lable fail_unlock
> in blkg_conf_prep() function.
How do you think about a wording variant like the following?
If a call of the function “blkg_lookup_check” failed,
release the previously allocated block group before jumping
to the target “fail_unlock” in the implementation of
the function “blkg_conf_prep”.
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
next reply other threads:[~2020-05-15 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 15:08 Markus Elfring [this message]
2020-05-18 11:34 ` [PATCH] blkcg: Fix memory leak in blkg_conf_prep() Wu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c670a6c-98c3-2b14-7438-09199506d92f@web.de \
--to=markus.elfring@web.de \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linfeilong@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=tj@kernel.org \
--cc=wubo40@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).