From: Joe Perches <joe@perches.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Christian Brauner <christian.brauner@ubuntu.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] .clang-format: update column limit
Date: Thu, 11 Jun 2020 03:36:34 -0700 [thread overview]
Message-ID: <4c6f8d63817cbc51765fd0b3046f81dccbd17ec7.camel@perches.com> (raw)
In-Reply-To: <CANiq72=BbGqXmiG8+1QuJnLXMTwNjUg9WuWR9eJcLMHZ=k5hQw@mail.gmail.com>
On Thu, 2020-06-11 at 12:03 +0200, Miguel Ojeda wrote:
> Hi Joe,
>
> On Wed, Jun 10, 2020 at 7:13 PM Joe Perches <joe@perches.com> wrote:
> > Ii think this is a not a good change.
> >
> > If you read the commit log you provided, it ways
> > "staying withing 80 columns is certainly still _preferred_"
>
> Yes, but the related email discussions were not about establishing a
> new hard limit, but about avoiding such hard limits for
> historical/technical reasons.
Exactly. So don't set a new hard limit of 100.
This would _always_ wrap lines to 100 columns when
80 columns is still preferred.
Imagine using a 100 column limit where a statement still
fits on 2 lines. Now imagine the same statement wrapped
at 80 columns still fitting on 2 lines.
Which would you prefer and why?
next prev parent reply other threads:[~2020-06-11 10:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 12:51 [PATCH] .clang-format: update column limit Christian Brauner
2020-06-10 15:55 ` Miguel Ojeda
2020-06-10 15:58 ` Nathan Chancellor
2020-06-10 16:23 ` Sedat Dilek
2020-06-10 17:13 ` Joe Perches
2020-06-10 17:32 ` Christian Brauner
2020-06-11 10:03 ` Miguel Ojeda
2020-06-11 10:36 ` Joe Perches [this message]
2020-06-11 11:54 ` Miguel Ojeda
2020-06-11 16:22 ` Joe Perches
2020-06-11 18:51 ` Miguel Ojeda
2020-06-11 19:26 ` Joe Perches
2020-06-22 0:03 ` Miguel Ojeda
2023-12-18 10:18 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c6f8d63817cbc51765fd0b3046f81dccbd17ec7.camel@perches.com \
--to=joe@perches.com \
--cc=christian.brauner@ubuntu.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).