From: Praveen Kumar <kumarpraveen@linux.microsoft.com>
To: Wei Liu <wei.liu@kernel.org>,
Linux on Hyper-V List <linux-hyperv@vger.kernel.org>
Cc: virtualization@lists.linux-foundation.org,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Michael Kelley <mikelley@microsoft.com>,
Vineeth Pillai <viremana@linux.microsoft.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
Nuno Das Neves <nunodasneves@linux.microsoft.com>,
pasha.tatashin@soleen.com, Jonathan Corbet <corbet@lwn.net>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Dexuan Cui <decui@microsoft.com>,
Lillian Grassin-Drake <ligrassi@microsoft.com>,
Muminul Islam <muislam@microsoft.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>
Subject: Re: [RFC v1 7/8] mshv: implement in-kernel device framework
Date: Wed, 4 Aug 2021 00:42:22 +0530 [thread overview]
Message-ID: <4c851046-35f8-28aa-03dd-859f2ade3446@linux.microsoft.com> (raw)
In-Reply-To: <20210709114339.3467637-8-wei.liu@kernel.org>
On 09-07-2021 17:13, Wei Liu wrote:
> This is basically the same code adopted from KVM. The main user case is
> the future MSHV-VFIO bridge device. We don't have any plan to support
> in-kernel device emulation yet, but it wouldn't hurt to make the code
> more flexible.
>
> Signed-off-by: Wei Liu <wei.liu@kernel.org>
> ---
> Documentation/virt/mshv/api.rst | 12 +++
> drivers/hv/mshv_main.c | 181 ++++++++++++++++++++++++++++++++
> include/linux/mshv.h | 57 ++++++++++
> include/uapi/linux/mshv.h | 36 +++++++
> 4 files changed, 286 insertions(+)
>
> diff --git a/Documentation/virt/mshv/api.rst b/Documentation/virt/mshv/api.rst
> index 56a6edfcfe29..7d35dd589831 100644
> --- a/Documentation/virt/mshv/api.rst
> +++ b/Documentation/virt/mshv/api.rst
> @@ -170,4 +170,16 @@ Can be used to get/set various properties of a partition.
> Some properties can only be set at partition creation. For these, there are
> parameters in MSHV_CREATE_PARTITION.
>
> +3.12 MSHV_CREATE_DEVICE
> +-----------------------
> +:Type: partition ioctl
> +:Parameters: struct mshv_create_device
> +:Returns: 0 on success
> +
> +Can be used to create an in-kernel device.
> +
> +If the MSHV_CREATE_DEVICE_TEST flag is set, only test whether the
> +device type is supported (not necessarily whether it can be created
> +in the current vm).
>
> +Currently only supports VFIO type device.
> diff --git a/drivers/hv/mshv_main.c b/drivers/hv/mshv_main.c
> index 4cbc520471e4..84c774a561de 100644
> --- a/drivers/hv/mshv_main.c
> +++ b/drivers/hv/mshv_main.c
> @@ -20,6 +20,8 @@
> #include <linux/random.h>
> #include <linux/mshv.h>
> #include <linux/mshv_eventfd.h>
> +#include <linux/hyperv.h>
> +#include <linux/nospec.h>
> #include <asm/mshyperv.h>
>
> #include "mshv.h"
> @@ -33,6 +35,7 @@ static int mshv_vp_release(struct inode *inode, struct file *filp);
> static long mshv_vp_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg);
> static struct mshv_partition *mshv_partition_get(struct mshv_partition *partition);
> static void mshv_partition_put(struct mshv_partition *partition);
> +static void mshv_partition_put_no_destroy(struct mshv_partition *partition);
> static int mshv_partition_release(struct inode *inode, struct file *filp);
> static long mshv_partition_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg);
> static int mshv_dev_open(struct inode *inode, struct file *filp);
> @@ -912,6 +915,172 @@ mshv_partition_ioctl_set_msi_routing(struct mshv_partition *partition,
> return ret;
> }
>
> +static int mshv_device_ioctl_attr(struct mshv_device *dev,
> + int (*accessor)(struct mshv_device *dev,
> + struct mshv_device_attr *attr),
> + unsigned long arg)
> +{
> + struct mshv_device_attr attr;
> +
> + if (!accessor)
> + return -EPERM;
> +
> + if (copy_from_user(&attr, (void __user *)arg, sizeof(attr)))
> + return -EFAULT;
> +
> + return accessor(dev, &attr);
> +}
> +
> +static long mshv_device_ioctl(struct file *filp, unsigned int ioctl,
> + unsigned long arg)
> +{
> + struct mshv_device *dev = filp->private_data;
> +
> + switch (ioctl) {
> + case MSHV_SET_DEVICE_ATTR:
> + return mshv_device_ioctl_attr(dev, dev->ops->set_attr, arg);
> + case MSHV_GET_DEVICE_ATTR:
> + return mshv_device_ioctl_attr(dev, dev->ops->get_attr, arg);
> + case MSHV_HAS_DEVICE_ATTR:
> + return mshv_device_ioctl_attr(dev, dev->ops->has_attr, arg);
> + default:
> + if (dev->ops->ioctl)
> + return dev->ops->ioctl(dev, ioctl, arg);
> +
> + return -ENOTTY;
> + }
Have seen some static analyzer tool cribbing here of not returning any error.
If you feel OK, please move the 'return -ENOTTY' down after switch block. Thanks.
> +}
> +
> +static int mshv_device_release(struct inode *inode, struct file *filp)
> +{
> + struct mshv_device *dev = filp->private_data;
> + struct mshv_partition *partition = dev->partition;
> +
> + if (dev->ops->release) {
> + mutex_lock(&partition->mutex);
> + list_del(&dev->partition_node);
> + dev->ops->release(dev);
> + mutex_unlock(&partition->mutex);
> + }
> +
> + mshv_partition_put(partition);
> + return 0;
> +}
> +
> +static const struct file_operations mshv_device_fops = {
> + .unlocked_ioctl = mshv_device_ioctl,
> + .release = mshv_device_release,
> +};
> +
> +static const struct mshv_device_ops *mshv_device_ops_table[MSHV_DEV_TYPE_MAX];
> +
> +int mshv_register_device_ops(const struct mshv_device_ops *ops, u32 type)
> +{
> + if (type >= ARRAY_SIZE(mshv_device_ops_table))
> + return -ENOSPC;
> +
> + if (mshv_device_ops_table[type] != NULL)
> + return -EEXIST;
> +
> + mshv_device_ops_table[type] = ops;
> + return 0;
> +}
> +
> +void mshv_unregister_device_ops(u32 type)
> +{
> + if (type >= ARRAY_SIZE(mshv_device_ops_table))
> + return;
> + mshv_device_ops_table[type] = NULL;
> +}
> +
> +static long
> +mshv_partition_ioctl_create_device(struct mshv_partition *partition,
> + void __user *user_args)
> +{
> + long r;
> + struct mshv_create_device tmp, *cd;
> + struct mshv_device *dev;
> + const struct mshv_device_ops *ops;
> + int type;
> +
> + if (copy_from_user(&tmp, user_args, sizeof(tmp))) {
> + r = -EFAULT;
> + goto out;
> + }
> +
> + cd = &tmp;
> +
> + if (cd->type >= ARRAY_SIZE(mshv_device_ops_table)) {
> + r = -ENODEV;
> + goto out;
> + }
> +
> + type = array_index_nospec(cd->type, ARRAY_SIZE(mshv_device_ops_table));
> + ops = mshv_device_ops_table[type];
> + if (ops == NULL) {
> + r = -ENODEV;
> + goto out;
> + }
> +
> + if (cd->flags & MSHV_CREATE_DEVICE_TEST) {
> + r = 0;
> + goto out;
> + }
> +
> + dev = kzalloc(sizeof(*dev), GFP_KERNEL_ACCOUNT);
> + if (!dev) {
> + r = -ENOMEM;
> + goto out;
> + }
> +
> + dev->ops = ops;
> + dev->partition = partition;
> +
> + r = ops->create(dev, type);
> + if (r < 0) {
> + kfree(dev);
> + goto out;
> + }
> +
> + list_add(&dev->partition_node, &partition->devices);
> +
> + if (ops->init)
> + ops->init(dev);
> +
> + mshv_partition_get(partition);
> + r = anon_inode_getfd(ops->name, &mshv_device_fops, dev, O_RDWR | O_CLOEXEC);
> + if (r < 0) {
> + mshv_partition_put_no_destroy(partition);
> + list_del(&dev->partition_node);
> + ops->destroy(dev);
I hope ops->destroy will free dev as well ?
> + goto out;
> + }
> +
> + cd->fd = r;
> + r = 0;
> +
> + if (copy_to_user(user_args, &tmp, sizeof(tmp))) {
> + r = -EFAULT;
I don't think we will be cleaning up anything ? Or do we need to?
> + goto out;
> + }
> +out:
> + return r;
> +}
> +
Regards,
~Praveen.
next prev parent reply other threads:[~2021-08-03 19:12 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 11:43 [RFC v1 0/8] MSHV: add PV-IOMMU driver Wei Liu
2021-07-09 11:43 ` [RFC v1 1/8] x86/hyperv: export hv_build_pci_dev_id Wei Liu
2021-07-09 11:43 ` [RFC v1 2/8] asm-generic/hyperv: add device domain definitions Wei Liu
2021-07-09 11:43 ` [RFC v1 3/8] intel/vt-d: make DMAR table parsing code more flexible Wei Liu
2021-07-09 12:56 ` Robin Murphy
2021-07-09 13:42 ` Wei Liu
2021-07-09 11:43 ` [RFC v1 4/8] intel/vt-d: export intel_iommu_get_resv_regions Wei Liu
2021-07-09 14:17 ` Lu Baolu
2021-07-09 14:21 ` Wei Liu
2021-07-09 11:43 ` [RFC v1 5/8] mshv: add paravirtualized IOMMU support Wei Liu
2021-08-03 18:40 ` Praveen Kumar
2021-08-03 21:47 ` Wei Liu
2021-08-04 6:43 ` Praveen Kumar
2021-08-10 10:46 ` Wei Liu
2021-07-09 11:43 ` [RFC v1 6/8] mshv: command line option to skip devices in PV-IOMMU Wei Liu
2021-07-09 12:46 ` Robin Murphy
2021-07-09 13:34 ` Wei Liu
2021-08-03 18:50 ` Praveen Kumar
2021-08-03 21:56 ` Wei Liu
2021-08-04 7:03 ` Praveen Kumar
2021-08-10 10:04 ` Wei Liu
2021-07-09 11:43 ` [RFC v1 7/8] mshv: implement in-kernel device framework Wei Liu
2021-07-09 13:02 ` Matthew Wilcox
2021-07-09 13:50 ` Wei Liu
2021-07-09 15:32 ` Matthew Wilcox
2021-07-09 16:27 ` Wei Liu
2021-07-09 16:38 ` Matthew Wilcox
2021-07-09 19:14 ` Wei Liu
2021-07-09 19:48 ` Matthew Wilcox
2021-07-09 20:11 ` Wei Liu
2021-08-03 19:12 ` Praveen Kumar [this message]
2021-08-03 22:04 ` Wei Liu
2021-07-09 11:43 ` [RFC v1 8/8] mshv: add vfio bridge device Wei Liu
2021-08-03 19:27 ` Praveen Kumar
2021-08-10 10:52 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c851046-35f8-28aa-03dd-859f2ade3446@linux.microsoft.com \
--to=kumarpraveen@linux.microsoft.com \
--cc=corbet@lwn.net \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=ligrassi@microsoft.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=muislam@microsoft.com \
--cc=nunodasneves@linux.microsoft.com \
--cc=pasha.tatashin@soleen.com \
--cc=sthemmin@microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=viremana@linux.microsoft.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).