From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12956C2B9F4 for ; Mon, 14 Jun 2021 14:28:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC2C6611C0 for ; Mon, 14 Jun 2021 14:28:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234235AbhFNOaJ (ORCPT ); Mon, 14 Jun 2021 10:30:09 -0400 Received: from mail-oi1-f181.google.com ([209.85.167.181]:38566 "EHLO mail-oi1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232809AbhFNOaJ (ORCPT ); Mon, 14 Jun 2021 10:30:09 -0400 Received: by mail-oi1-f181.google.com with SMTP id q10so10336177oij.5 for ; Mon, 14 Jun 2021 07:28:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cS1D61UWM7D7f9J7258UNtSJuuL2xJgwPnJmsK1CIKE=; b=Drq4euRexolAYmKsw5YnQsTY+Ac/Qk3DtXRFtHBS2i9AvbFlh2UncXnNxs//tB8OdG ZSeIEHyqDQdGg7U4fbjvSRz+XnA9w1bsdX2BIxzhiPbgWumFBjtoTxx99m1SNaHyVBTF OFW5ki9GHslxZBUTKuwX1FKmf5mElQfY29yNc59EwGAFK7Nx9nDJBBI19HrJrAe5+f3F /FK4zekhGvSs3dLferQ5veRiKFDjRQFeZ2Gr6JiJwjugnjWk7B8Nh+j0KEhwPCU7X/Rx t25ppOPClB8MCpzBH9fDz74VXG+JQp2XaGr2xbkPBYO41Wxd01wGnkF3YLXSRW1Mpv0V k4pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cS1D61UWM7D7f9J7258UNtSJuuL2xJgwPnJmsK1CIKE=; b=N2FqSHUYgxtDrU+/pKhg0LR8QDU9PD1fTZ27S7cZLG3BoIY0C5y/uae89x5rv8LZAE bympkanphCZ/aRd88jh49+LRrN162nXyz0SZ2JKzF+aRZ24+jYFttCy7lRF/ZUIaM9jD ZjbnsGuvgwXKCEETMiQUj5j1Wb5cuLMxK9TiKUVEGOfsIVRJaML5kb55JDJv6vUjr6q+ FI9PSxa+QnRM8ojSJlQgXBYrzvchFa5rMe+5ARCD9ATYNnMZV/n6sjCULue+4XkoX+Vs JeaZyNKU6Axp+zA9sD1iDgxbdRlBFu5DW3MflsVxId/qjTpcy/2u8UyFPVKS8U4F9R56 MotA== X-Gm-Message-State: AOAM532PTqaqO9QeLTl4RFN2KwNW7NS15zyrxS/vUctyNxyOF/4qukuz b6FnhoU5Yq/Udh6BeUsrMGQSbw== X-Google-Smtp-Source: ABdhPJy3zOStR4414HcnVU/hu0fUTjtzRD0SvMKTxiAT0JtYMmXILVT3id2ffgfVSbs6vvST1aQoyA== X-Received: by 2002:aca:b406:: with SMTP id d6mr10656391oif.71.1623680825976; Mon, 14 Jun 2021 07:27:05 -0700 (PDT) Received: from [192.168.1.134] ([198.8.77.61]) by smtp.gmail.com with ESMTPSA id x187sm2981180oia.17.2021.06.14.07.27.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jun 2021 07:27:05 -0700 (PDT) Subject: Re: [PATCH v2 RESEND] ata: ahci_sunxi: Disable DIPM To: Timo Sigurdsson , mripard@kernel.org, wens@csie.org, jernej.skrabec@siol.net, linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: sergei.shtylyov@gmail.com, gregkh@linuxfoundation.org, oliver@schinagl.nl References: <20210614072539.3307-1-public_timo.s@silentcreek.de> From: Jens Axboe Message-ID: <4c873409-db09-31ea-485e-daa0433c674b@kernel.dk> Date: Mon, 14 Jun 2021 08:27:04 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210614072539.3307-1-public_timo.s@silentcreek.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/14/21 1:25 AM, Timo Sigurdsson wrote: > DIPM is unsupported or broken on sunxi. Trying to enable the power > management policy med_power_with_dipm on an Allwinner A20 SoC based board > leads to immediate I/O errors and the attached SATA disk disappears from > the /dev filesystem. A reset (power cycle) is required to make the SATA > controller or disk work again. The A10 and A20 SoC data sheets and manuals > don't mention DIPM at all [1], so it's fair to assume that it's simply not > supported. But even if it was, it should be considered broken and best be > disabled in the ahci_sunxi driver. Applied, thanks. -- Jens Axboe