From: Jes Sorensen <jes.sorensen@gmail.com>
To: Daniel Drake <drake@endlessm.com>, Chris Chiu <chiu@endlessm.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
David Miller <davem@davemloft.net>,
linux-wireless <linux-wireless@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Upstreaming Team <linux@endlessm.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] rtl8xxxu: Fix wifi low signal strength issue of RTL8723BU
Date: Tue, 2 Jul 2019 08:42:19 -0400 [thread overview]
Message-ID: <4c99866e-55b7-8852-c078-6b31dce21ee4@gmail.com> (raw)
In-Reply-To: <CAD8Lp44R0a1=fVi=fGv69w1ppdcaFV01opkdkhaX-eJ=K=tYeA@mail.gmail.com>
On 7/1/19 4:27 AM, Daniel Drake wrote:
> Hi Chris,
>
> On Thu, Jun 27, 2019 at 5:53 PM Chris Chiu <chiu@endlessm.com> wrote:
>> The WiFi tx power of RTL8723BU is extremely low after booting. So
>> the WiFi scan gives very limited AP list and it always fails to
>> connect to the selected AP. This module only supports 1x1 antenna
>> and the antenna is switched to bluetooth due to some incorrect
>> register settings.
>>
>> This commit hand over the antenna control to PTA, the wifi signal
>> will be back to normal and the bluetooth scan can also work at the
>> same time. However, the btcoexist still needs to be handled under
>> different circumstances. If there's a BT connection established,
>> the wifi still fails to connect until disconneting the BT.
>>
>> Signed-off-by: Chris Chiu <chiu@endlessm.com>
>
> Really nice work finding this!
>
> I know that after this change, you plan to bring over the btcoexist
> code from the vendor driver (or at least the minimum required code)
> for a more complete fix, but I'm curious how you found these magic
> register values and how they compare to the values used by the vendor
> driver with btcoexist?
We definitely don't want to bring over the vendor code, since it's a
pile of spaghetti, but we probably need to get something sorted. This
went down the drain when the bluetooth driver was added without taking
it into account - long after this driver was merged.
Cheers,
Jes
next prev parent reply other threads:[~2019-07-02 12:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 9:52 [PATCH] rtl8xxxu: Fix wifi low signal strength issue of RTL8723BU Chris Chiu
2019-07-01 5:09 ` Chris Chiu
2019-07-01 8:27 ` Daniel Drake
2019-07-02 8:01 ` Chris Chiu
2019-07-03 7:51 ` Daniel Drake
2019-07-02 12:42 ` Jes Sorensen [this message]
2019-07-03 7:42 ` Daniel Drake
2019-07-03 12:59 ` Jes Sorensen
2019-07-05 3:44 ` Daniel Drake
2019-07-05 18:27 ` Jes Sorensen
2019-07-05 23:26 ` Larry Finger
2019-07-02 12:44 ` Jes Sorensen
2019-07-03 3:25 ` Chris Chiu
2019-07-03 13:01 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c99866e-55b7-8852-c078-6b31dce21ee4@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chiu@endlessm.com \
--cc=davem@davemloft.net \
--cc=drake@endlessm.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).