From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752595AbdFLKJ5 (ORCPT ); Mon, 12 Jun 2017 06:09:57 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:49943 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751992AbdFLKJ4 (ORCPT ); Mon, 12 Jun 2017 06:09:56 -0400 Subject: Re: [PATCH v4] mfd: lp87565: Add lp87565 PMIC support To: Javier Martinez Canillas References: <1496894894-6969-1-git-send-email-j-keerthy@ti.com> <20170609142855.tfixhw3cb5qjkcne@rob-hp-laptop> <7596b39a-3135-7cca-e3dc-18c05cf54a8b@ti.com> <7e352aa3-4483-1fa4-e424-cc90f62cdf46@ti.com> <20170612091133.kt2doom32bun6ujp@dell> <373e82d1-39fb-9cbb-300a-aa8a99544cdc@ti.com> CC: Lee Jones , Rob Herring , Mark Brown , "linux-omap@vger.kernel.org" , Linux Kernel , "devicetree@vger.kernel.org" , Mark Rutland From: Keerthy Message-ID: <4cafbf6b-4fb6-d8f1-2b29-cfd11ea60942@ti.com> Date: Mon, 12 Jun 2017 15:39:45 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 12 June 2017 02:57 PM, Javier Martinez Canillas wrote: > Hello Lee and Keerthy, > > On Mon, Jun 12, 2017 at 11:17 AM, Keerthy wrote: >> >> >> On Monday 12 June 2017 02:41 PM, Lee Jones wrote: >>> On Sun, 11 Jun 2017, Keerthy wrote: >>> >>>> >>>> >>>> On Sunday 11 June 2017 10:36 AM, Keerthy wrote: >>>>> >>>>> >>>>> On Friday 09 June 2017 07:58 PM, Rob Herring wrote: >>>>>> On Thu, Jun 08, 2017 at 09:38:14AM +0530, Keerthy wrote: >>>>>>> The LP87565 chip is a power management IC for Portable Navigation Systems >>>>>>> and Tablet Computing devices. It contains the following components: >>>>>>> >>>>>>> - Configurable Bucks(Single and multi-phase). >>>>>>> - Configurable General Purpose Output Signals (GPO). >>>>>>> >>>>>>> The LP87565-Q1 variant device uses two 2-phase outputs configuration, >>>>>>> Buck0 is master for Buck0/1 output and Buck2 is master for Buck2/3 >>>>>>> output. >>>>>>> >>>> >>>> Lee Jones, >>>> >>>> Shall i add back i2c_device_id as pointed here: >>>> http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1417316.html >>> >>> Hasn't that been fixed yet? >>> > > There are only 2 patch series remaining to be merged so we can finally > fix this in the I2C core, making sure that no drivers will be > regressed. One of the series is for MFD and have been around for a > while (it already contains all the relevant acks AFAICT), it would be > very helpful if you can look at it and merge if you think is correct: > > https://lkml.org/lkml/2017/5/4/11 > >>> I guess so then. :( >> >> Okay. So with that i assume i should reintroduce probe instead of probe_new. >> > > It's orthogonal, you can have probe_new and also the I2C device ID > table (the OF table will be used for matching, you just need the I2C > table to export the aliases with MODULE_DEVICE_TABLE(i2c,.. ). I believe the whole purpose of comments on probe_new was to remove the i2c device ID. With that needed i will stick to probe for now and once the above series mentioned by you gets in and all the dependencies for probe_new are cleared i will send out a separate patch. > > Best regards, > Javier >