From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426521AbdD3QfU (ORCPT ); Sun, 30 Apr 2017 12:35:20 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:34867 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1036041AbdD3QfK (ORCPT ); Sun, 30 Apr 2017 12:35:10 -0400 Subject: Re: [PATCH 3/7] iio: adc: twl4030: Drop twl4030_get_madc_conversion() To: Sebastian Reichel , Sebastian Reichel , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jean Delvare , Guenter Roeck Cc: J Keerthy , linux-iio@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170427153012.32310-1-sebastian.reichel@collabora.co.uk> <20170427153012.32310-4-sebastian.reichel@collabora.co.uk> From: Jonathan Cameron Message-ID: <4cb8938c-69c2-4881-3061-565a6f479b39@kernel.org> Date: Sun, 30 Apr 2017 17:35:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <20170427153012.32310-4-sebastian.reichel@collabora.co.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-GH Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/04/17 16:30, Sebastian Reichel wrote: > Drop legacy twl4030_get_madc_conversion() method. It has been > used by drivers to get madc data before it conversion to IIO > API. There are no users in the mainline kernel anymore. > > Signed-off-by: Sebastian Reichel Acked-by: Jonathan Cameron > --- > drivers/iio/adc/twl4030-madc.c | 21 --------------------- > include/linux/i2c/twl4030-madc.h | 1 - > 2 files changed, 22 deletions(-) > > diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c > index 0c74869a540a..88e44066ef82 100644 > --- a/drivers/iio/adc/twl4030-madc.c > +++ b/drivers/iio/adc/twl4030-madc.c > @@ -642,27 +642,6 @@ int twl4030_madc_conversion(struct twl4030_madc_request *req) > } > EXPORT_SYMBOL_GPL(twl4030_madc_conversion); > > -int twl4030_get_madc_conversion(int channel_no) > -{ > - struct twl4030_madc_request req; > - int temp = 0; > - int ret; > - > - req.channels = (1 << channel_no); > - req.method = TWL4030_MADC_SW2; > - req.active = 0; > - req.raw = 0; > - req.func_cb = NULL; > - ret = twl4030_madc_conversion(&req); > - if (ret < 0) > - return ret; > - if (req.rbuf[channel_no] > 0) > - temp = req.rbuf[channel_no]; > - > - return temp; > -} > -EXPORT_SYMBOL_GPL(twl4030_get_madc_conversion); > - > /** > * twl4030_madc_set_current_generator() - setup bias current > * > diff --git a/include/linux/i2c/twl4030-madc.h b/include/linux/i2c/twl4030-madc.h > index 1c0134dd3271..0c919ebb31e0 100644 > --- a/include/linux/i2c/twl4030-madc.h > +++ b/include/linux/i2c/twl4030-madc.h > @@ -143,5 +143,4 @@ struct twl4030_madc_user_parms { > }; > > int twl4030_madc_conversion(struct twl4030_madc_request *conv); > -int twl4030_get_madc_conversion(int channel_no); > #endif >