From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752633AbcHLUal (ORCPT ); Fri, 12 Aug 2016 16:30:41 -0400 Received: from smtp10.smtpout.orange.fr ([80.12.242.132]:20231 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752575AbcHLUaj (ORCPT ); Fri, 12 Aug 2016 16:30:39 -0400 X-ME-Helo: [127.0.0.1] X-ME-Date: Fri, 12 Aug 2016 22:30:31 +0200 X-ME-IP: 92.140.156.102 Subject: Re: [PATCH 2/2] be2iscsi: Fix some error messages To: Julia Lawall References: <1470996165-31131-1-git-send-email-christophe.jaillet@wanadoo.fr> Cc: jayamohan.kallickal@avagotech.com, jejb@linux.vnet.ibm.com, ketan.mukadam@avagotech.com, sony.john@avagotech.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Newsgroups: gmane.linux.scsi,gmane.linux.kernel,gmane.linux.kernel.janitors From: Christophe JAILLET Message-ID: <4cd24bc3-7953-479a-1dbe-2aac9299ce13@wanadoo.fr> Date: Fri, 12 Aug 2016 22:30:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Antivirus: avast! (VPS 160812-1, 12/08/2016), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 12/08/2016 à 12:30, Julia Lawall a écrit : > On Fri, 12 Aug 2016, Christophe JAILLET wrote: > >> This fixes: >> - missing spaces in string split on several lines >> - extra spaces after ':' >> - missing '\n' at the end of some messages >> - too long lines > I think that the strings should be concatenated, even if they go past 80 > chars. I'm surprised checkpatch didn't complain. > > julia checkpatch did complain. In this file, all logging messages were written with split lines when too long, so I considered that it was better to keep it like that. I will resubmit if the patch gets some interest and if a maintainer ask for concatenated messages. CJ --- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus