From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90789C433E9 for ; Thu, 11 Mar 2021 14:11:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B06564E77 for ; Thu, 11 Mar 2021 14:11:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233424AbhCKOLO (ORCPT ); Thu, 11 Mar 2021 09:11:14 -0500 Received: from mail1.perex.cz ([77.48.224.245]:45564 "EHLO mail1.perex.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233260AbhCKOKn (ORCPT ); Thu, 11 Mar 2021 09:10:43 -0500 Received: from mail1.perex.cz (localhost [127.0.0.1]) by smtp1.perex.cz (Perex's E-mail Delivery System) with ESMTP id B8372A003F; Thu, 11 Mar 2021 15:10:41 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.perex.cz B8372A003F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=perex.cz; s=default; t=1615471841; bh=Bhu1hDvSD7EWbTKsxAFB2tJYDMaa5wo79+M5tRAK6BI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=HTT+Bq3kJ3UYeyOMv2tiJX0w31pVpZBp6WOXecs7nvohel595E3OIHR69qT0mL2rA OuTTpKSTnetJY6g2xGXK9vAWcYAUgFWBer7l3cHYuZRAoXUyoPSnmSrtAywYXOofjl LORRfgurCgJkhC5SOVRoJi8zdZYzKN+CmYTMwcTQ= Received: from p1gen2.localdomain (unknown [192.168.100.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: perex) by mail1.perex.cz (Perex's E-mail Delivery System) with ESMTPSA; Thu, 11 Mar 2021 15:10:31 +0100 (CET) Subject: Re: No sound cards detected on Kabylake laptops after upgrade to kernel 5.8 To: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= , Chris Chiu , Cezary Rojewski Cc: pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, yang.jie@linux.intel.com, Takashi Iwai , Linux Kernel , liam.r.girdwood@linux.intel.com, broonie@kernel.org References: From: Jaroslav Kysela Message-ID: <4cec5ad9-7322-c3c4-7cd0-e2fea37eefcf@perex.cz> Date: Thu, 11 Mar 2021 15:10:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne 11. 03. 21 v 11:40 Amadeusz Sławiński napsal(a): > On 3/11/2021 11:24 AM, Jaroslav Kysela wrote: >> Dne 11. 03. 21 v 6:50 Chris Chiu napsal(a): >>> On Tue, Mar 9, 2021 at 11:29 PM Cezary Rojewski >>> wrote: >>>> >>>> On 2021-03-09 1:19 PM, Chris Chiu wrote: >>>>> Hi Guys, >>>>> We have received reports that on some Kabylake laptops (Acer Swift >>>>> SF314-54/55 and Lenovo Yoga C930...etc), all sound cards no longer be >>>>> detected after upgrade to kernel later than 5.8. These laptops have >>>>> one thing in common, all of them have Realtek audio codec and connect >>>>> the internal microphone to DMIC of the Intel SST controller either >>>>> [8086:9d71] or [8086:9dc8]. Please refer to >>>>> https://bugzilla.kernel.org/show_bug.cgi?id=201251#c246 and >>>>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1915117. >>>>> >>>>> From the dmesg from kernel 5.8, the sound related parts only show >>>>> as follows but the expected snd_hda_codec_realtek and the snd_soc_skl >>>>> are not even loaded then. >>>>> [ 13.357495] snd_hda_intel 0000:00:1f.3: DSP detected with PCI >>>>> class/subclass/prog-if info 0x040100 >>>>> [ 13.357500] snd_hda_intel 0000:00:1f.3: Digital mics found on >>>>> Skylake+ platform, using SST driver >>>>> >>>>> Building the kernel with the CONFIG_SND_SOC_INTEL_KBL removed can >>>>> load the snd_hda_codec_realtek successfully and the pulseaudio and >>>>> alsa-utils can detect the sound cards again. The result of bisecting >>>>> between kernel 5.4 and 5.8 also get similar result, reverting the >>>>> commit "ALSA: hda: Allow SST driver on SKL and KBL platforms with >>>>> DMIC" can fix the issue. I tried to generate the required firmware for >>>>> snd_soc_skl but it did not help. Please refer to what I did in >>>>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1915117/comments/14 >>>>> and https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1915117/comments/18. >>>>> >>>>> Since the skl_hda_dsp_generic-tplg.bin and dfw_sst.bin are not in >>>>> the linux-firmware. The Intel SST support for Skylake family is not >>>>> yet complete. Can we simply revert the "ALSA: hda: Allow SST driver on >>>>> SKL and KBL platforms with DMIC" in the current stage and wait for SOF >>>>> support for Skylake family? Or please suggest a better solution for >>>>> this. Thanks >>>>> >>>>> Chris >>>>> >>>> >>>> Hello Chris, >>>> >>>> Guide: "Linux: HDA+DMIC with skylake driver" [1] should help >>>> understanding history behind the problem as well as fixing it. >>>> >>>> Upstream skylake driver - snd_soc_skl - is intended to support HDA DSP + >>>> DMIC configuration via means of snd_soc_skl_hda_dsp machine board >>>> driver. You _may_ switch to legacy HDAudio driver - snd_hda_intel - >>>> losing DMIC support in the process. To remove any confusion - for >>>> Skylake and Kabylake platforms, snd_soc_skl is your option. >>>> >>>> Now, due to above, I doubt any skylake-related topology has ever been >>>> upstreamed to linux-firmware as a) most boards are I2S-based, these are >>>> used by our clients which we support via separate channel b) hda >>>> dsp+dmic support on linux for missing until early 2020. >>>> >>>> Topologies for most common skylake driver configurations: >>>> - skl/kbl with i2s rt286 >>>> - apl/glk with i2s rt298 >>>> - with hda dsp >>>> can be found in alsa-topology-conf [2]. >>>> >>>> Standard, official tool called 'alsatplg' is capable of compiling these >>>> into binary form which, after being transferred to /lib/firmware/ may be >>>> consumed by the driver during runtime. >>>> I have no problem with providing precompiled binaries to linux-firmware, >>>> if that's what community wants. >>>> >>>> Regards, >>>> Czarek >>>> >>>> >>> >>> I think the guild [1] is too complicated for normal users to fix the problem. >>> Given it's not only the internal microphone being affected, it's no sound >>> devices being created at all so no audio functions can work after kernel 5.8. >>> >>> Is there any potential problem to built-in the " with hda dsp" precompiled >>> binary in linux-firmware? >> >> How do you distribute the SOF firmware? I'm going to include those binary >> topology files to the SOF firmware package for Fedora. Perhaps, you may follow >> this. >> > > Wouldn't it make more sense to distribute binaries along with confs from > which they are build, which are already installed by alsa-topology package? > Similarly Ubuntu could use alsa-topology-conf package... >From the packaging perpective, it would be another package which should be forcefully installed on x86_64 containing few files (and it's unclear if the list will be extended in future). Also the .conf files are not required for the operation. But it's just my suggestion, other distributions can choose a different approach. I just created Makefile [1] which may help with the packaging, because the topology .conf -> fw .bin relation is _unclear_ for may of us for those SST drivers. If you know more information (you can fill the rules for other topology files), please, share it with us. Jaroslav [1] https://github.com/alsa-project/alsa-topology-conf/blob/master/Makefile -- Jaroslav Kysela Linux Sound Maintainer; ALSA Project; Red Hat, Inc.