From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v4 1/7] perf util: Create streams
Date: Tue, 1 Sep 2020 10:26:25 +0800 [thread overview]
Message-ID: <4cef1f08-e1c1-3227-24f2-be3108ea4d99@linux.intel.com> (raw)
In-Reply-To: <20200831135609.GE406859@krava>
Hi Jiri,
On 8/31/2020 9:56 PM, Jiri Olsa wrote:
> On Tue, Aug 25, 2020 at 07:35:07AM +0800, Jin Yao wrote:
>
> SNIP
>
>> + int nr_streams_max,
>> + enum stream_type type)
>> +{
>> + struct evsel_streams *es;
>> + int nr_evsel = evlist->core.nr_entries, ret = -1;
>> +
>> + es = create_evsel_streams(nr_evsel, nr_streams_max);
>> + if (!es)
>> + return NULL;
>> +
>> + if (type == STREAM_CALLCHAIN)
>> + ret = evlist_init_callchain_streams(evlist, es, nr_evsel);
>> +
>> + if (ret) {
>> + free_evsel_streams(es, nr_evsel);
>> + return NULL;
>> + }
>> +
>> + return es;
>> +}
>> diff --git a/tools/perf/util/stream.h b/tools/perf/util/stream.h
>> new file mode 100644
>> index 000000000000..a8a0172b4d13
>> --- /dev/null
>> +++ b/tools/perf/util/stream.h
>> @@ -0,0 +1,30 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +#ifndef __PERF_STREAM_H
>> +#define __PERF_STREAM_H
>> +
>> +#include "callchain.h"
>> +
>> +enum stream_type {
>> + STREAM_NONE = 0,
>> + STREAM_CALLCHAIN
>
> do you plan to add more types?
>
> jirka
>
Thanks for looking at this patch series.
So far, no more types in plan. :)
Thanks
Jin Yao
next prev parent reply other threads:[~2020-09-01 2:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 23:35 [PATCH v4 0/7] perf: Stream comparison Jin Yao
2020-08-24 23:35 ` [PATCH v4 1/7] perf util: Create streams Jin Yao
2020-08-31 13:56 ` Jiri Olsa
2020-09-01 2:26 ` Jin, Yao [this message]
2020-09-01 20:09 ` Jiri Olsa
2020-09-02 8:16 ` Jin, Yao
2020-08-24 23:35 ` [PATCH v4 2/7] perf util: Get the evsel_streams by evsel_idx Jin Yao
2020-08-24 23:35 ` [PATCH v4 3/7] perf util: Compare two streams Jin Yao
2020-08-24 23:35 ` [PATCH v4 4/7] perf util: Link stream pair Jin Yao
2020-08-24 23:35 ` [PATCH v4 5/7] perf util: Calculate the sum of total streams hits Jin Yao
2020-08-24 23:35 ` [PATCH v4 6/7] perf util: Report hot streams Jin Yao
2020-08-24 23:35 ` [PATCH v4 7/7] perf diff: Support hot streams comparison Jin Yao
-- strict thread matches above, loose matches on Subject: below --
2020-05-26 6:09 [PATCH v4 0/7] perf: Stream comparison Jin Yao
2020-05-26 6:09 ` [PATCH v4 1/7] perf util: Create streams Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cef1f08-e1c1-3227-24f2-be3108ea4d99@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).