From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3C02C07E9D for ; Mon, 26 Sep 2022 16:42:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229684AbiIZQmG (ORCPT ); Mon, 26 Sep 2022 12:42:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229652AbiIZQlV (ORCPT ); Mon, 26 Sep 2022 12:41:21 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AF46149D38; Mon, 26 Sep 2022 08:29:05 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 3555B660225B; Mon, 26 Sep 2022 16:29:03 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1664206143; bh=nlq4IdmFkNAjJjqacvnPjUw6nzph3yIh2k8BmqgKtv0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=apBByvvEKv5QOCPxB2lfg8MkEDZjihxHUfLC8RJf72npPocYyK+Jg+xC9lbGVV90i TT4l9p1jTX1Q4CnTRBdynjjwsUv+RpC/gza0Ai56MKWcTajHghhpmKyxHE8GKl2kjV UPIRUDRshDBbDgKgBC8Qp+Ga8MkPNe7APt5KQsyTSiYuXHb2tR0q4RjpgLjNBpOR3c RD0DaDBT9FdvNbvb8tgsj5TRGIrgb+Fw7iIYi3DF0xvM1kZOkHlz3RvPljkrEadXrQ ZxwbKze82h03odNQQ/u6gihNO6TSolPSxi6lMkH8qc2LIswVn/jdR8yoW6cHZjNN9A yOGP4m/PuB/oA== Message-ID: <4d1e8600-f73d-8d2b-2e7a-1b75be7624bd@collabora.com> Date: Mon, 26 Sep 2022 17:29:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2] arm64: dts: mt8192: Add vcodec lat and core nodes Content-Language: en-US To: Allen-KH Cheng , Matthias Brugger , Rob Herring , Krzysztof Kozlowski Cc: Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20220926105047.19419-1-allen-kh.cheng@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220926105047.19419-1-allen-kh.cheng@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 26/09/22 12:50, Allen-KH Cheng ha scritto: > Add vcodec lat and core nodes for mt8192 SoC. > > Signed-off-by: Allen-KH Cheng > Tested-by: Chen-Yu Tsai > --- > Change in v1: > * Replace node names with video-codec > [Allen-KH Cheng ] > --- > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 60 ++++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > index 6b20376191a7..214dfc6b0ed1 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > @@ -1449,6 +1449,66 @@ > power-domains = <&spm MT8192_POWER_DOMAIN_ISP2>; > }; > > + vcodec_dec: video-codec@16000000 { > + compatible = "mediatek,mt8192-vcodec-dec"; > + reg = <0 0x16000000 0 0x1000>; > + mediatek,scp = <&scp>; > + iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>; > + dma-ranges = <0x1 0x0 0x0 0x40000000 0x0 0xfff00000>; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges = <0 0 0 0x16000000 0 0x26000>; > + > + vcodec_lat: video-codec@10000 { Allen, this won't work :-( Check Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml ...the schema requires vcodec-lat@[0-9a-f] and vcodec-core@[0-9a-f]. If you want to call them all video-codec@addr, you have to also fix the schema. P.S.: Did you try to run `make dtbs_check`? Regards, Angelo