linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Price <steven.price@arm.com>
To: ChunyouTang <tangchunyou@163.com>,
	robh@kernel.org, tomeu.vizoso@collabora.com,
	alyssa.rosenzweig@collabora.com, airlied@linux.ie,
	daniel@ffwll.ch
Cc: ChunyouTang <tangchunyou@icubecorp.cn>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panfrost:modify 'break' to 'continue' to traverse the circulation
Date: Fri, 18 Jun 2021 13:43:25 +0100	[thread overview]
Message-ID: <4d289eed-59f2-161a-40d1-2a434a1955c2@arm.com> (raw)
In-Reply-To: <20210617080414.1940-1-tangchunyou@163.com>

On 17/06/2021 09:04, ChunyouTang wrote:
> From: ChunyouTang <tangchunyou@icubecorp.cn>
> 
> The 'break' can cause 'Memory manager not clean during takedown'
> 
> It cannot use break to finish the circulation,it should use
> 
> continue to traverse the circulation.it should put every mapping
> 
> which is not NULL.

You don't appear to have answered my question about whether you've
actually seen this happen (and ideally what circumstances). In my
previous email[1] I explained why I don't think this is needed. You need
to convince me that I've overlooked something.

Thanks,

Steve

[1] https://lore.kernel.org/r/31644881-134a-2d6e-dddf-e658a3a8176b%40arm.com

> Signed-off-by: ChunyouTang <tangchunyou@icubecorp.cn>
> ---
>  drivers/gpu/drm/panfrost/panfrost_job.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 6003cfeb1322..52bccc1d2d42 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -281,7 +281,7 @@ static void panfrost_job_cleanup(struct kref *ref)
>  	if (job->mappings) {
>  		for (i = 0; i < job->bo_count; i++) {
>  			if (!job->mappings[i])
> -				break;
> +				continue;
>  
>  			atomic_dec(&job->mappings[i]->obj->gpu_usecount);
>  			panfrost_gem_mapping_put(job->mappings[i]);
> 


  reply	other threads:[~2021-06-18 12:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17  8:04 ChunyouTang
2021-06-18 12:43 ` Steven Price [this message]
2021-06-19  3:09   ` Chunyou Tang
2021-06-21 10:45     ` Steven Price
2021-06-22  1:31       ` Chunyou Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d289eed-59f2-161a-40d1-2a434a1955c2@arm.com \
    --to=steven.price@arm.com \
    --cc=airlied@linux.ie \
    --cc=alyssa.rosenzweig@collabora.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tangchunyou@163.com \
    --cc=tangchunyou@icubecorp.cn \
    --cc=tomeu.vizoso@collabora.com \
    --subject='Re: [PATCH] drm/panfrost:modify '\''break'\'' to '\''continue'\'' to traverse the circulation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).