From: Steev Klimaszewski <steev@kali.org>
To: Brian Masney <bmasney@redhat.com>,
andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org
Cc: quic_shazhuss@quicinc.com, konrad.dybcio@linaro.org,
robh+dt@kernel.org, johan+linaro@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, ahalaney@redhat.com,
echanude@redhat.com
Subject: Re: [PATCH v3 0/7] dts: qcom: sc8280xp: add i2c, spi, and rng nodes
Date: Wed, 21 Dec 2022 13:41:52 -0600 [thread overview]
Message-ID: <4d434dd7-cd3c-ed53-c337-4cf1ba018aef@kali.org> (raw)
In-Reply-To: <20221220192854.521647-1-bmasney@redhat.com>
On 12/20/22 1:28 PM, Brian Masney wrote:
> This patch series adds the i2c and spi nodes that are missing on the
> sc8280xp platform. Since I am already making changes to sc8280xp.dtsi
> in this series, I also included a change to enable the rng node for this
> platform as well.
>
> The first three patches in this series are new in v2 and rename one node
> at a time to try to make the review easier. Each patch has a changelog.
>
> Note that this series needs to be applied on top of:
> [PATCH v5] arm64: dts: qcom: sa8540p-ride: enable pcie2a node
> https://lore.kernel.org/lkml/20221213095922.11649-1-quic_shazhuss@quicinc.com/
>
> Changes from v2 to v3:
> - Reordered rng node in patch 7 so that it's sorted correctly by address
> - Since I respun the series, I made Konrad's sort order suggestion to
> the state nodes since I'm making changes here.
> - Collected R-b and T-b tags.
>
> Brian Masney (7):
> arm64: dts: qcom: sc8280xp: rename qup2_uart17 to uart17
> arm64: dts: qcom: sc8280xp: rename qup2_i2c5 to i2c21
> arm64: dts: qcom: sc8280xp: rename qup0_i2c4 to i2c4
> arm64: dts: qcom: sc8280xp: add missing i2c nodes
> arm64: dts: qcom: sc8280xp: add missing spi nodes
> arm64: dts: qcom: sa8540p-ride: add i2c nodes
> arm64: dts: qcom: sc8280xp: add rng device tree node
>
> arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 12 +-
> arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 91 ++-
> arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 160 ++--
> .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 178 ++---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 725 +++++++++++++++++-
> 5 files changed, 983 insertions(+), 183 deletions(-)
One note, and this isn't due to your patches at all, but the touchscreen
on the Thinkpad X13s needs to be manually bound in order to work via
echo 1-0010 | sudo tee /sys/bus/i2c/drivers/i2c_hid_of/bind - this patch
does not affect that, though I had hoped maybe it would.
Tested on the Lenovo Thinkpad X13s
Tested-by: Steev Klimaszewski <steev@kali.org>
next prev parent reply other threads:[~2022-12-21 19:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 19:28 [PATCH v3 0/7] dts: qcom: sc8280xp: add i2c, spi, and rng nodes Brian Masney
2022-12-20 19:28 ` [PATCH v3 1/7] arm64: dts: qcom: sc8280xp: rename qup2_uart17 to uart17 Brian Masney
2022-12-23 9:31 ` Johan Hovold
2022-12-20 19:28 ` [PATCH v3 2/7] arm64: dts: qcom: sc8280xp: rename qup2_i2c5 to i2c21 Brian Masney
2022-12-23 9:38 ` Johan Hovold
2022-12-20 19:28 ` [PATCH v3 3/7] arm64: dts: qcom: sc8280xp: rename qup0_i2c4 to i2c4 Brian Masney
2022-12-23 9:40 ` Johan Hovold
2022-12-20 19:28 ` [PATCH v3 4/7] arm64: dts: qcom: sc8280xp: add missing i2c nodes Brian Masney
2022-12-23 10:37 ` Johan Hovold
2022-12-23 12:22 ` Brian Masney
2022-12-23 12:42 ` Konrad Dybcio
2022-12-23 13:05 ` Johan Hovold
2022-12-23 13:05 ` Konrad Dybcio
2022-12-20 19:28 ` [PATCH v3 5/7] arm64: dts: qcom: sc8280xp: add missing spi nodes Brian Masney
2022-12-23 10:39 ` Johan Hovold
2022-12-20 19:28 ` [PATCH v3 6/7] arm64: dts: qcom: sa8540p-ride: add i2c nodes Brian Masney
2022-12-20 19:28 ` [PATCH v3 7/7] arm64: dts: qcom: sc8280xp: add rng device tree node Brian Masney
2022-12-21 20:44 ` Konrad Dybcio
2022-12-21 19:41 ` Steev Klimaszewski [this message]
2023-01-04 14:14 ` [PATCH v3 0/7] dts: qcom: sc8280xp: add i2c, spi, and rng nodes Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d434dd7-cd3c-ed53-c337-4cf1ba018aef@kali.org \
--to=steev@kali.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=echanude@redhat.com \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_shazhuss@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).