From: Benjamin Gray <bgray@linux.ibm.com>
To: "Erhard F." <erhard_f@mailbox.org>, linuxppc-dev@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: 6.2-rc7 fails building on Talos II: memory.c:(.text+0x2e14): undefined reference to `hash__tlb_flush'
Date: Thu, 16 Feb 2023 16:56:40 +1100 [thread overview]
Message-ID: <4d498c7d1808e5e9090c43822e7c79447e11bbce.camel@linux.ibm.com> (raw)
In-Reply-To: <20230216005535.6bff7aa6@yea>
On Thu, 2023-02-16 at 00:55 +0100, Erhard F. wrote:
> Just noticed a build failure on 6.2-rc7 for my Talos 2 (.config
> attached):
>
> # make
> CALL scripts/checksyscalls.sh
> UPD include/generated/utsversion.h
> CC init/version-timestamp.o
> LD .tmp_vmlinux.kallsyms1
> ld: ld: DWARF error: could not find abbrev number 6
> mm/memory.o: in function `unmap_page_range':
> memory.c:(.text+0x2e14): undefined reference to `hash__tlb_flush'
> ld: memory.c:(.text+0x2f8c): undefined reference to `hash__tlb_flush'
> ld: ld: DWARF error: could not find abbrev number 3117
> mm/mmu_gather.o: in function `tlb_remove_table':
> mmu_gather.c:(.text+0x584): undefined reference to `hash__tlb_flush'
> ld: mmu_gather.c:(.text+0x6c4): undefined reference to
> `hash__tlb_flush'
> ld: mm/mmu_gather.o: in function `tlb_flush_mmu':
> mmu_gather.c:(.text+0x80c): undefined reference to `hash__tlb_flush'
> ld: mm/mmu_gather.o:mmu_gather.c:(.text+0xbe0): more undefined
> references to `hash__tlb_flush' follow
> make[1]: *** [scripts/Makefile.vmlinux:35: vmlinux] Fehler 1
> make: *** [Makefile:1264: vmlinux] Error 2
>
> As 6.2-rc6 was good on this machine I did a quick bisect which
> revealed this commit:
>
> # git bisect bad
> 1665c027afb225882a5a0b014c45e84290b826c2 is the first bad commit
> commit 1665c027afb225882a5a0b014c45e84290b826c2
> Author: Michael Ellerman <mpe@ellerman.id.au>
> Date: Tue Jan 31 22:14:07 2023 +1100
>
> powerpc/64s: Reconnect tlb_flush() to hash__tlb_flush()
>
> Commit baf1ed24b27d ("powerpc/mm: Remove empty hash__ functions")
> removed some empty hash MMU flushing routines, but got a bit
> overeager
> and also removed the call to hash__tlb_flush() from tlb_flush().
>
> In regular use this doesn't lead to any noticable breakage, which
> is a
> little concerning. Presumably there are flushes happening via
> other
> paths such as arch_leave_lazy_mmu_mode(), and/or a bit of luck.
>
> Fix it by reinstating the call to hash__tlb_flush().
>
> Fixes: baf1ed24b27d ("powerpc/mm: Remove empty hash__ functions")
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Link:
> https://lore.kernel.org/r/20230131111407.806770-1-mpe@ellerman.id.au
>
> arch/powerpc/include/asm/book3s/64/tlbflush.h | 2 ++
> 1 file changed, 2 insertions(+)
>
>
> Regards,
> Erhard
Looks like the `return` on the radix version wasn't added back, so it
falls through to the hash call too.
next prev parent reply other threads:[~2023-02-16 5:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 23:55 6.2-rc7 fails building on Talos II: memory.c:(.text+0x2e14): undefined reference to `hash__tlb_flush' Erhard F.
2023-02-16 5:56 ` Benjamin Gray [this message]
2023-02-16 10:09 ` Linux regression tracking (Thorsten Leemhuis)
2023-02-18 4:44 ` Linux regression tracking #update (Thorsten Leemhuis)
[not found] ` <a2b50c13-6ddc-e310-559e-ee429e96c527@csgroup.eu>
2023-02-16 11:10 ` Erhard F.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d498c7d1808e5e9090c43822e7c79447e11bbce.camel@linux.ibm.com \
--to=bgray@linux.ibm.com \
--cc=erhard_f@mailbox.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).