From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7CCDC433DB for ; Mon, 1 Feb 2021 21:53:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B13064D92 for ; Mon, 1 Feb 2021 21:53:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229651AbhBAVxu (ORCPT ); Mon, 1 Feb 2021 16:53:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbhBAVxr (ORCPT ); Mon, 1 Feb 2021 16:53:47 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03A55C0613D6 for ; Mon, 1 Feb 2021 13:53:07 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id nm1so448664pjb.3 for ; Mon, 01 Feb 2021 13:53:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=N6tU/hkqNUMYsHM0IUqTnCXIZDB8nb2QJ5YhEZMP+tE=; b=WZi+UCs9TIbCUorANOZIg1lacKJyrLAcxNgjqYv2hNfd0YCcWVUr7BGsWFb1LJIeln UelOikGZSyHtnr85jilxjPtGr9ZrM138I2fxLqj7VzG8BUYH/s6nx67rVjthtycndIQX L3fGAZD1a7UEf5TUkzE8WDjRzAznsbPZomOWfxve4P0qqnIX7Kb2xvvbK6O5gtVEHUqw vBxXHHfsMMe0vFxzNCHdspQP6sYm6XDirkDgPU/KcOLz+prvZoNhzG2Py/aSLNALyU/E 3RqDEnEBvUa0+i2+s4SRsa3p3nhYWglPsFE5vBFTZtM/lOExGpoLoTxaNVZstQlDpviD 6EFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=N6tU/hkqNUMYsHM0IUqTnCXIZDB8nb2QJ5YhEZMP+tE=; b=DV1aNbLVzI/88fcLLRkH4Bgh8JlOKYGxtH2gIOz3zQCl0zOSqE7imKtt/3KI0fqPLI edfnCL1D8HxcY8tsggxN/Iqvt/SBew0QrZv/oltZig9fcbZiF8/in9p0fRSpMsbyIF59 BewepvA6hSLZY8N/WsNWtY3RwUFswIZeiW0HzdvNnXyPb8NH32vnub7SybzQ8qGGCk6I SR7IFCgwfAX5RDQbQUM/gaV/HHwrKxtXQAV/0zrsq4jX+FaAaXEeQaIAhIcCaktHigaV nojFDw7e1/kZaMM2NLx1korGlRCKrS9bKEy1VbK/UQO2xMALx68dyQlaLhd7Wda6TTNc MFLA== X-Gm-Message-State: AOAM530vnpPpNyDZw4FTh317+eZ4SGiD8UhMbDvUN8uajGr8J+3xvWEM kt/813/nNOJKc+2QW/ByF5ZP1w== X-Google-Smtp-Source: ABdhPJycALujIbA4WvZUkZggYo0Ocv7rTw3rYtZTgJzBXpeooffmD1f4WnTwFRQBCWLZpToH49e2uA== X-Received: by 2002:a17:902:c106:b029:de:af88:80ed with SMTP id 6-20020a170902c106b02900deaf8880edmr19001691pli.35.1612216386313; Mon, 01 Feb 2021 13:53:06 -0800 (PST) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id k128sm18715106pfd.137.2021.02.01.13.53.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 13:53:05 -0800 (PST) Date: Mon, 1 Feb 2021 13:53:03 -0800 (PST) From: David Rientjes To: Ben Widawsky cc: linux-cxl@vger.kernel.org, Dan Williams , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-pci@vger.kernel.org, Bjorn Helgaas , Chris Browy , Christoph Hellwig , Ira Weiny , Jon Masters , Jonathan Cameron , Rafael Wysocki , Randy Dunlap , Vishal Verma , daniel.lll@alibaba-inc.com, "John Groves (jgroves)" , "Kelley, Sean V" Subject: Re: [PATCH 05/14] cxl/mem: Register CXL memX devices In-Reply-To: <20210201171051.m3cbr3udczxwghqh@intel.com> Message-ID: <4d62a125-91e1-d32-66d3-1216d751f9b8@google.com> References: <20210130002438.1872527-1-ben.widawsky@intel.com> <20210130002438.1872527-6-ben.widawsky@intel.com> <20210201171051.m3cbr3udczxwghqh@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Feb 2021, Ben Widawsky wrote: > > > diff --git a/Documentation/ABI/testing/sysfs-bus-cxl b/Documentation/ABI/testing/sysfs-bus-cxl > > > new file mode 100644 > > > index 000000000000..fe7b87eba988 > > > --- /dev/null > > > +++ b/Documentation/ABI/testing/sysfs-bus-cxl > > > @@ -0,0 +1,26 @@ > > > +What: /sys/bus/cxl/devices/memX/firmware_version > > > +Date: December, 2020 > > > +KernelVersion: v5.12 > > > +Contact: linux-cxl@vger.kernel.org > > > +Description: > > > + (RO) "FW Revision" string as reported by the Identify > > > + Memory Device Output Payload in the CXL-2.0 > > > + specification. > > > + > > > +What: /sys/bus/cxl/devices/memX/ram/size > > > +Date: December, 2020 > > > +KernelVersion: v5.12 > > > +Contact: linux-cxl@vger.kernel.org > > > +Description: > > > + (RO) "Volatile Only Capacity" as reported by the > > > + Identify Memory Device Output Payload in the CXL-2.0 > > > + specification. > > > + > > > +What: /sys/bus/cxl/devices/memX/pmem/size > > > +Date: December, 2020 > > > +KernelVersion: v5.12 > > > +Contact: linux-cxl@vger.kernel.org > > > +Description: > > > + (RO) "Persistent Only Capacity" as reported by the > > > + Identify Memory Device Output Payload in the CXL-2.0 > > > + specification. > > > > Aren't volatile and persistent capacities expressed in multiples of 256MB? > > As of the spec today, volatile and persistent capacities are required to be > in multiples of 256MB, however, future specs may not have such a requirement and > I think keeping sysfs ABI easily forward portable makes sense. > Makes sense, can we add that these are expressed in bytes or is that already implied?