From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751330AbdIEHCl (ORCPT ); Tue, 5 Sep 2017 03:02:41 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:60807 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751236AbdIEHCj (ORCPT ); Tue, 5 Sep 2017 03:02:39 -0400 Subject: Re: [PATCH] mm, sparse: fix typo in online_mem_sections To: Michal Hocko , Andrew Morton References: <20170904112210.3401-1-mhocko@kernel.org> Cc: Vlastimil Babka , linux-mm@kvack.org, LKML , Michal Hocko From: Anshuman Khandual Date: Tue, 5 Sep 2017 12:32:28 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170904112210.3401-1-mhocko@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17090507-0048-0000-0000-0000025AD3D0 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17090507-0049-0000-0000-0000480F2F77 Message-Id: <4d648f70-325d-3f60-8620-94c232b380d8@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-09-05_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709050108 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/04/2017 04:52 PM, Michal Hocko wrote: > From: Michal Hocko > > online_mem_sections accidentally marks online only the first section in > the given range. This is a typo which hasn't been noticed because I > haven't tested large 2GB blocks previously. All users of Section sizes are normally less than 2GB. Could you please elaborate why this never got noticed before ?