Re: User space out of memory approach

From: Edjard Souza Mota <edjard@gmail.com>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: Mauricio Lin <mauriciolin@gmail.com>,
	linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: User space out of memory approach
Date: Tue, 11 Jan 2005 01:17:01 +0200	[thread overview]
Message-ID: <4d6522b90501101517420fced6@mail.gmail.com> (raw)
In-Reply-To: <20050110200514.GA18796@logos.cnet>

Hi,

> 
> Sorry, I misunderstood. Should have read the code before shouting.

Better shouting then shooting :)!

br

Edjard

> 
> The feature is interesting - several similar patches have been around with similar
> functionality (people who need usually write their own, I've seen a few), but none
> has ever been merged, even though it is an important requirement for many users.
> 
> This is simple, an ordered list of candidate PIDs. IMO something similar to this
> should be merged. Andrew ?
> 
> Few comments about the code:
> 
>  retry:
> -       p = select_bad_process();
> +       printk(KERN_DEBUG "A good walker leaves no tracks.\n");
> +       p = select_process();
> 
> You want to fallback to select_bad_process() if no candidate has been selected at
> select_process().
> 
> You also want to move "oom" to /proc/sys/vm/.
> 
> 

-- 
"In a world without fences ... who needs Gates?"