From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9421C433E0 for ; Mon, 4 Jan 2021 15:38:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8793222286 for ; Mon, 4 Jan 2021 15:38:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727650AbhADPiZ (ORCPT ); Mon, 4 Jan 2021 10:38:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24295 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727522AbhADPiY (ORCPT ); Mon, 4 Jan 2021 10:38:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609774618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wcrw+NpZAZ4cyYiYlRnmiZrkDJtugvQ8JiKGHsSokGg=; b=dvuDxYFIMaZzbdQazGP7r/f3LMA/XNzKQ2veSswH1bs2sVCFaxUUeVZB6kyhBN7a9L1Tun Qhq7Xg9E8eK40PDnWMw32VE4BFP8kXIMaRwIAbbOtU3fGQy4lL9TJxeWzwH+hMmL/dIFvM 50YygqeJxM7ZxOaZSYiz8cgvf3jC6XM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-567-aFEXv2VNOQ2AdcHHwmbh5g-1; Mon, 04 Jan 2021 10:36:54 -0500 X-MC-Unique: aFEXv2VNOQ2AdcHHwmbh5g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 81D7EBBEE0; Mon, 4 Jan 2021 15:36:52 +0000 (UTC) Received: from [10.36.114.59] (ovpn-114-59.ams2.redhat.com [10.36.114.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2C5E3271B0; Mon, 4 Jan 2021 15:36:51 +0000 (UTC) Subject: Re: [PATCH v1 1/4] s390/kvm: VSIE: stop leaking host addresses To: Claudio Imbrenda Cc: linux-kernel@vger.kernel.org, borntraeger@de.ibm.com, frankja@linux.ibm.com, kvm@vger.kernel.org, linux-s390@vger.kernel.org, stable@vger.kernel.org References: <20201218141811.310267-1-imbrenda@linux.ibm.com> <20201218141811.310267-2-imbrenda@linux.ibm.com> <20210104145802.7a2274a2@ibm-vm> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <4d7ea3de-61b7-af89-a3d4-5a4b5749f667@redhat.com> Date: Mon, 4 Jan 2021 16:36:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210104145802.7a2274a2@ibm-vm> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> In that case, it's pretty much a random number (of a random page used >> as a leave page table) and does not let g1 identify locations of >> symbols etc. If so, I don't think this is a "clear security issue" >> and suggest squashing this into the actual fix (#p4 I assume). > > yeah __maybe__ I overstated the importance ;) > > But I would still like to keep it as a separate patch, looks more > straightforward to me > I don't see a need to split this up. Just fix it right away. -- Thanks, David / dhildenb