From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D20B6C4332D for ; Wed, 13 Jan 2021 18:34:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92EE820658 for ; Wed, 13 Jan 2021 18:34:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728510AbhAMSea (ORCPT ); Wed, 13 Jan 2021 13:34:30 -0500 Received: from smtprelay0185.hostedemail.com ([216.40.44.185]:57348 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728441AbhAMSe3 (ORCPT ); Wed, 13 Jan 2021 13:34:29 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id B373F100E7B46; Wed, 13 Jan 2021 18:33:47 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: move37_071180b27520 X-Filterd-Recvd-Size: 2521 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Wed, 13 Jan 2021 18:33:45 +0000 (UTC) Message-ID: <4d985bb8b1b9b382cf8e818a8761aa6268d7bc62.camel@perches.com> Subject: Re: [PATCH] compiler.h: Raise minimum version of GCC to 5.1 for arm64 From: Joe Perches To: Masahiro Yamada , Catalin Marinas Cc: linux-arm-kernel , Will Deacon , Arnd Bergmann , Russell King , Linus Torvalds , Nick Desaulniers , Theodore Ts'o , "Cc: Android Kernel" , Linux Kernel Mailing List , Peter Zijlstra , Florian Weimer Date: Wed, 13 Jan 2021 10:33:43 -0800 In-Reply-To: References: <20210112224832.10980-1-will@kernel.org> <161055398865.21762.12236232732054213928.b4-ty@arm.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-01-14 at 02:57 +0900, Masahiro Yamada wrote: > On Thu, Jan 14, 2021 at 1:08 AM Catalin Marinas wrote: > > > > On Tue, 12 Jan 2021 22:48:32 +0000, Will Deacon wrote: > > > GCC versions >= 4.9 and < 5.1 have been shown to emit memory references > > > beyond the stack pointer, resulting in memory corruption if an interrupt > > > is taken after the stack pointer has been adjusted but before the > > > reference has been executed. This leads to subtle, infrequent data > > > corruption such as the EXT4 problems reported by Russell King at the > > > link below. > > > > > > [...] > > > > Applied to arm64 (for-next/fixes), thanks! > > > > [1/1] compiler.h: Raise minimum version of GCC to 5.1 for arm64 > >       https://git.kernel.org/arm64/c/1f1244a5ddb7 [] > Maybe, we can raise the minimal version to gcc 5.1 > for all architectures. If really raising the required minimum, maybe use 7.1 so kasan v5 and fallthrough are always enabled too. https://gcc.gnu.org/releases.html GCC 7.1 May 2, 2017 GCC 5.1 April 22, 2015 GCC 4.9.0 April 22, 2014