From: "Landen Chao (趙皎宏)" <Landen.Chao@mediatek.com>
To: "olteanv@gmail.com" <olteanv@gmail.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"arinc9.unal@gmail.com" <arinc9.unal@gmail.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
Sean Wang <Sean.Wang@mediatek.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"dqfext@gmail.com" <dqfext@gmail.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"erkin.bozoglu@xeront.com" <erkin.bozoglu@xeront.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"arinc.unal@arinc9.com" <arinc.unal@arinc9.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH net 2/3] net: dsa: mt7530: move lowering TRGMII driving to mt7530_setup()
Date: Sun, 26 Mar 2023 18:13:49 +0000 [thread overview]
Message-ID: <4d9c562eb980642381cb43f65efb2ee13d742485.camel@mediatek.com> (raw)
In-Reply-To: <20230320190520.124513-2-arinc.unal@arinc9.com>
On Mon, 2023-03-20 at 22:05 +0300, arinc9.unal@gmail.com wrote:
>
> I asked this before, MT7530 DSA driver maintainers, please explain
> the code
> I mentioned on the second paragraph.
>
> ---
> @@ -2207,6 +2198,15 @@ mt7530_setup(struct dsa_switch *ds)
>
> mt7530_pll_setup(priv);
>
> + /* Lower Tx driving for TRGMII path */
> + for (i = 0; i < NUM_TRGMII_CTRL; i++)
> + mt7530_write(priv, MT7530_TRGMII_TD_ODT(i),
> + TD_DM_DRVP(8) | TD_DM_DRVN(8));
> +
I guess you ask this part, and I try my best to recall what the
original author said years ago.
It is used to adjust the RX delay of port 6 to match the tx
signal of the link partner.
> + for (i = 0; i < NUM_TRGMII_CTRL; i++)
> + mt7530_rmw(priv, MT7530_TRGMII_RD(i),
> + RD_TAP_MASK, RD_TAP(16));
> +
>
>
next prev parent reply other threads:[~2023-03-26 18:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 19:05 [PATCH net 1/3] net: dsa: mt7530: move enabling disabling core clock to mt7530_pll_setup() arinc9.unal
2023-03-20 19:05 ` [PATCH net 2/3] net: dsa: mt7530: move lowering TRGMII driving to mt7530_setup() arinc9.unal
2023-03-23 5:14 ` Jakub Kicinski
2023-03-26 18:13 ` Landen Chao (趙皎宏) [this message]
2023-04-04 19:37 ` Arınç ÜNAL
2023-03-20 19:05 ` [PATCH net 3/3] net: dsa: mt7530: move setting ssc_delta to PHY_INTERFACE_MODE_TRGMII case arinc9.unal
2023-03-23 5:20 ` [PATCH net 1/3] net: dsa: mt7530: move enabling disabling core clock to mt7530_pll_setup() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d9c562eb980642381cb43f65efb2ee13d742485.camel@mediatek.com \
--to=landen.chao@mediatek.com \
--cc=Sean.Wang@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=arinc9.unal@gmail.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=erkin.bozoglu@xeront.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).