From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752581AbdHKHVV (ORCPT ); Fri, 11 Aug 2017 03:21:21 -0400 Received: from mout.gmx.net ([212.227.17.21]:51043 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751440AbdHKHVT (ORCPT ); Fri, 11 Aug 2017 03:21:19 -0400 Subject: Re: [PATCH 4.4 01/58] parisc: Increase thread and stack size to 32kb To: Ben Hutchings , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20170809194146.501519882@linuxfoundation.org> <20170809194146.557693970@linuxfoundation.org> <1502415185.2047.29.camel@codethink.co.uk> From: Helge Deller Message-ID: <4d9db9cf-4ca4-85a8-ef0e-fbead61f6c15@gmx.de> Date: Fri, 11 Aug 2017 09:21:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502415185.2047.29.camel@codethink.co.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:KOEqRAaDbF44pOqkLCyljMlEjJCAsHzH45LxAPSepYwQI7CkAg8 GOFi8eFCFOFull/PuXzn6liDPSdihFiQZy9B4PCUIw7uh5Z6soyhUGmCztjVMvm9w9mFgjZ BDRgzXuyIhuyIVutysZP1Y8kHoOeXlG4DdWZvmVawRsAuSCMSZjohzZkXkmzQ2Q3k9kHcRl j226uXC6fURUBNtPRaFeQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:ehG0pq57bRw=:FE/onvbyY+SO5ZPFdmKTnl NzcnXk4w00V42Y9MQ4WdPDrtF1c/oUcknSzAKmE3182JmtYmfdp24YXBOLRj/mG3QoBijSG3m 7oJONsqw90YCJSZlMwwOgCY2RvY/rQWa6XNPK77oC/6r3wScxG/gVY1wqa2A69lH+LDWzXqb8 BLrS/hQ7/lZ4PNUvZUItP2+VzsAZCplimRyAyl7E8z5xk4L3YepL6H30oHfS4mmWx8cy3VGX7 zsIcXYbKZpSbyx8CSS1e0S/cwImlEdC8mhwGT7rglbZmAJTZ3qlzRZuFhKK1Tsk2gfClTOsbT cl3uZCFqycdLu4kf+8vJXVdQIl9tmkxjyv57nO+wnrmTcvr0/QvRbdGocefKwP8dcy6iifuTQ f8k8Hr9PdpN3jsuZt53mA/NA5QavBXetlivZMxizYUrylZ1dWPClatLYF+7tmiWVCA12WPDTO 3B8MJD3/c5A0CO8qPr1w3YjqOIPvzaAXP1GzqlqhlWvtiDyxzkR6JPDo/+f8oSmOmSWqGFvAY AbwGxZSKdsUm+G3zExezmwnJjMyggILKktJvvhatUgpibfpQV0sJKuTKGTjUS3CxGcYsWJrEW n3rwm2rMFtc5IwIEplUL/n2zDC701B+KNhT9GLdEFrmJB7aTbuGjpRoVW5gAbF4DOz97GOI8w xoNuRFGHis22L3qU8oel/aR5TfLWqTsK90+iKHJYBN4qI3KtEU8QzuO0FNSRgu+GM+hK6cIZ+ uBX8rryAkR/Zp+cFmQQ/XTNgyQ8DI7+L4vY5lgvst+JNERvtkInLbW/+10cy+vGVDQX7yRmkb tXF4uRpO/JVhWhcc2mpQErijQ8VuG4MGLRRtQOZyEKsG+F0YXU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.08.2017 03:33, Ben Hutchings wrote: > On Wed, 2017-08-09 at 12:41 -0700, Greg Kroah-Hartman wrote: >> 4.4-stable review patch. If anyone has any objections, please let me know. >> >> ------------------ >> >> From: Helge Deller >> >> commit 8f8201dfed91a43ac38c899c82f81eef3d36afd9 upstream. >> >> Since kernel 4.11 the thread and irq stacks on parisc randomly overflow >> the default size of 16k. The reason why stack usage suddenly grew is yet >> unknown. > > So we don't need this for 4.4. Correct. I had Cc: stable@vger.kernel.org # 4.11+ in the commit itself: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8f8201dfed91a43ac38c899c82f81eef3d36afd9 Helge > > Ben. > >> Signed-off-by: Helge Deller >> Signed-off-by: Helge Deller >> Signed-off-by: Greg Kroah-Hartman >> >> --- >> arch/parisc/include/asm/thread_info.h | 2 +- >> arch/parisc/kernel/irq.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> --- a/arch/parisc/include/asm/thread_info.h >> +++ b/arch/parisc/include/asm/thread_info.h >> @@ -34,7 +34,7 @@ struct thread_info { >> >> /* thread information allocation */ >> >> -#define THREAD_SIZE_ORDER 2 /* PA-RISC requires at least 16k stack */ >> +#define THREAD_SIZE_ORDER 3 /* PA-RISC requires at least 32k stack */ >> /* Be sure to hunt all references to this down when you change the size of >> * the kernel stack */ >> #define THREAD_SIZE (PAGE_SIZE << THREAD_SIZE_ORDER) >> --- a/arch/parisc/kernel/irq.c >> +++ b/arch/parisc/kernel/irq.c >> @@ -380,7 +380,7 @@ static inline int eirr_to_irq(unsigned l >> /* >> * IRQ STACK - used for irq handler >> */ >> -#define IRQ_STACK_SIZE (4096 << 2) /* 16k irq stack size */ >> +#define IRQ_STACK_SIZE (4096 << 3) /* 32k irq stack size */ >> >> union irq_stack_union { >> unsigned long stack[IRQ_STACK_SIZE/sizeof(unsigned long)]; >> >> >