From: Bean Huo <huobean@gmail.com>
To: Stanley Chu <stanley.chu@mediatek.com>, avri.altman@wdc.com
Cc: alim.akhtar@samsung.com, asutoshd@codeaurora.org,
jejb@linux.ibm.com, martin.petersen@oracle.com,
beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com,
cang@codeaurora.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] scsi: ufs: Cleanup completed request without interrupt notification
Date: Wed, 12 Aug 2020 16:42:39 +0200 [thread overview]
Message-ID: <4da0c324952861608bca14df77720e805be881e5.camel@gmail.com> (raw)
In-Reply-To: <1597236472.26065.9.camel@mtkswgap22>
On Wed, 2020-08-12 at 20:47 +0800, Stanley Chu wrote:
> Hi Avri, Bean,
>
> On Tue, 2020-08-11 at 16:18 +0200, Bean Huo wrote:
> > From: Stanley Chu <stanley.chu@mediatek.com>
> >
> > If somehow no interrupt notification is raised for a completed
> > request
> > and its doorbell bit is cleared by host, UFS driver needs to
> > cleanup
> > its outstanding bit in ufshcd_abort(). Otherwise, system may behave
> > abnormally by below flow:
> >
> > After ufshcd_abort() returns, this request will be requeued by SCSI
> > layer with its outstanding bit set. Any future completed request
> > will trigger ufshcd_transfer_req_compl() to handle all "completed
> > outstanding bits". In this time, the "abnormal outstanding bit"
> > will be detected and the "requeued request" will be chosen to
> > execute
> > request post-processing flow. This is wrong because this request is
> > still "alive".
> >
> > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> > Reviewed-by: Can Guo <cang@codeaurora.org>
> > Signed-off-by: Bean Huo <beanhuo@micron.com>
>
> Thanks Bean's patch integration.
>
> Like Avri's comment in https://patchwork.kernel.org/patch/11683381/
> I think you could add Acked-by tag from Avri.
>
Hi Avri
do I need to re-send the patchset to add your Acked-by tag?
or you will sign your acked-by statement and append this patch?
Thanks,
Bean
>
>
> Hi Avri,
>
> Please correct above description if required.
> Thanks for your review! : )
>
>
> Thanks,
>
> Stanley Chu
>
next prev parent reply other threads:[~2020-08-12 14:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 14:18 [PATCH v2 0/2] scsi: ufs: two fixups of ufshcd_abort() Bean Huo
2020-08-11 14:18 ` [PATCH v2 1/2] scsi: ufs: Cleanup completed request without interrupt notification Bean Huo
2020-08-12 12:47 ` Stanley Chu
2020-08-12 14:42 ` Bean Huo [this message]
2020-08-13 11:05 ` Avri Altman
2020-08-11 14:18 ` [PATCH v2 2/2] scsi: ufs: no need to send one Abort Task TM in case the task in DB was cleared Bean Huo
2020-08-14 9:27 ` Can Guo
2020-08-16 1:54 ` Stanley Chu
2020-08-18 3:12 ` [PATCH v2 0/2] scsi: ufs: two fixups of ufshcd_abort() Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4da0c324952861608bca14df77720e805be881e5.camel@gmail.com \
--to=huobean@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).