From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E9BEC433F5 for ; Fri, 3 Sep 2021 09:15:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5858F60F56 for ; Fri, 3 Sep 2021 09:15:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348727AbhICJQM (ORCPT ); Fri, 3 Sep 2021 05:16:12 -0400 Received: from foss.arm.com ([217.140.110.172]:39276 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348700AbhICJQL (ORCPT ); Fri, 3 Sep 2021 05:16:11 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5990D1FB; Fri, 3 Sep 2021 02:15:11 -0700 (PDT) Received: from [10.57.92.220] (unknown [10.57.92.220]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 226B23F694; Fri, 3 Sep 2021 02:15:09 -0700 (PDT) Subject: Re: [PATCH v2 7/9] perf cs-etm: Create ETE decoder To: James Clark , mathieu.poirier@linaro.org, leo.yan@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, mike.leach@linaro.org Cc: acme@kernel.org, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210806134109.1182235-1-james.clark@arm.com> <20210806134109.1182235-8-james.clark@arm.com> From: Suzuki K Poulose Message-ID: <4da533c0-8da6-00d4-1849-e210e163d326@arm.com> Date: Fri, 3 Sep 2021 10:15:07 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210806134109.1182235-8-james.clark@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/08/2021 14:41, James Clark wrote: > If the magic number indicates ETE instantiate a OCSD_BUILTIN_DCD_ETE > decoder instead of OCSD_BUILTIN_DCD_ETMV4I. ETE is the new trace feature > for Armv9. > > Testing performed > ================= > > * Old files with v0 and v1 headers for ETMv4 still open correctly > * New files with new magic number open on new versions of perf > * New files with new magic number fail to open on old versions of perf > * Decoding with the ETE decoder results in the same output as the ETMv4 > decoder as long as there are no new ETE packet types > > Signed-off-by: James Clark Changes look good to me with my limited knowledge about the decoder facing code. FWIW, Acked-by: Suzuki K Poulose