From: "Ing. Josua Mayer" <josua.mayer@jm0.eu>
To: Christian Gmeiner <christian.gmeiner@gmail.com>,
linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Lucas Stach <l.stach@pengutronix.de>,
Russell King <linux+etnaviv@armlinux.org.uk>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/etnaviv: fix external abort seen on GC600 rev 0x19
Date: Sun, 23 Aug 2020 16:27:03 +0200 [thread overview]
Message-ID: <4dbee9c7-8a59-9250-ab13-394cbab689a8@jm0.eu> (raw)
In-Reply-To: <20200821181731.94852-1-christian.gmeiner@gmail.com>
Hi Christian,
I have formally tested the patch with 5.7.10 - and it doesn't resolve
the issue - sadly :(
From my testing, the reads on
VIVS_HI_CHIP_PRODUCT_ID
VIVS_HI_CHIP_ECO_ID
need to be conditional - while
VIVS_HI_CHIP_CUSTOMER_ID
seems to be okay.
br
josau Mayer
Am 21.08.20 um 20:17 schrieb Christian Gmeiner:
> It looks like that this GPU core triggers an abort when
> reading VIVS_HI_CHIP_PRODUCT_ID and/or VIVS_HI_CHIP_CUSTOMER_ID.
>
> I looked at different versions of Vivante's kernel driver and did
> not found anything about this issue or what feature flag can be
> used. So go the simplest route and do not read these two registers
> on the affected GPU core.
>
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> Reported-by: Josua Mayer <josua.mayer@jm0.eu>
> Fixes: 815e45bbd4d3 ("drm/etnaviv: determine product, customer and eco id")
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> index d5a4cd85a0f6..d3906688c2b3 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> @@ -337,10 +337,17 @@ static void etnaviv_hw_identify(struct etnaviv_gpu *gpu)
>
> gpu->identity.model = gpu_read(gpu, VIVS_HI_CHIP_MODEL);
> gpu->identity.revision = gpu_read(gpu, VIVS_HI_CHIP_REV);
> - gpu->identity.product_id = gpu_read(gpu, VIVS_HI_CHIP_PRODUCT_ID);
> - gpu->identity.customer_id = gpu_read(gpu, VIVS_HI_CHIP_CUSTOMER_ID);
> gpu->identity.eco_id = gpu_read(gpu, VIVS_HI_CHIP_ECO_ID);
>
> + /*
> + * Reading these two registers on GC600 rev 0x19 result in a
> + * unhandled fault: external abort on non-linefetch
> + */
> + if (!etnaviv_is_model_rev(gpu, GC600, 0x19)) {
> + gpu->identity.product_id = gpu_read(gpu, VIVS_HI_CHIP_PRODUCT_ID);
> + gpu->identity.customer_id = gpu_read(gpu, VIVS_HI_CHIP_CUSTOMER_ID);
> + }
> +
> /*
> * !!!! HACK ALERT !!!!
> * Because people change device IDs without letting software
>
next prev parent reply other threads:[~2020-08-23 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 18:17 [PATCH] drm/etnaviv: fix external abort seen on GC600 rev 0x19 Christian Gmeiner
2020-08-23 14:27 ` Ing. Josua Mayer [this message]
2020-08-23 19:10 ` Christian Gmeiner
2020-08-23 19:19 ` Russell King - ARM Linux admin
2020-08-24 11:04 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dbee9c7-8a59-9250-ab13-394cbab689a8@jm0.eu \
--to=josua.mayer@jm0.eu \
--cc=airlied@linux.ie \
--cc=christian.gmeiner@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).