From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7C1EC433DB for ; Fri, 5 Mar 2021 00:23:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9F2B64F3D for ; Fri, 5 Mar 2021 00:23:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230455AbhCEAXN (ORCPT ); Thu, 4 Mar 2021 19:23:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbhCEAXM (ORCPT ); Thu, 4 Mar 2021 19:23:12 -0500 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B31AC061574 for ; Thu, 4 Mar 2021 16:23:12 -0800 (PST) Received: by mail-qv1-xf32.google.com with SMTP id 2so199140qvd.0 for ; Thu, 04 Mar 2021 16:23:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek-ca.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8oQVoZxbOpv1MAN0E+Lnn1at05JDDd6c6sg5qtjxamw=; b=Z8Z0Tq2TrgX9ihGAVrq/1f4udIW3734GFDpSvmXM3iASqbDkWWLASm1qlZNPqKOvug kMTmvEo8O/Jctp3Y0ptSTJ3xZ8FGTVyVgVyEktyf3V33g6ZYDRTeFVCVhgOKQyyOnv6A OruXBbs/p32GJeDascR0k5EA8lL1epg/ROrqAveVpZkhqisj25CWTRkoDazpFhjY8XhE dXOZ/mWQy5qhKoE4VmfWmceoMKg/p7pc2gXhX6O0GvdZtwaWL1N7oh5U+qX1HcWt3ABA /0FAT42KjjOczdc5UyAZIUmYK2ulReuMtd3qL9f8J7sXPH3zTbnmJ0EiSja/X0mRhZ4w bMuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8oQVoZxbOpv1MAN0E+Lnn1at05JDDd6c6sg5qtjxamw=; b=qiRMWiFd3FPiPpOxuMd2Q67/njZgPmAQ4ba9+jKoYoAPD+eOopuc1mBLaZp+OmOMrC vZVw8oQ94u7GX7W4ki9w0fLyHUbcrc44Tu6kIhMxlFy7CrV+EGm0uGG1sAlKl3ycE0P3 ZxXOrpiEHV1SaiMN6zahDPEmQ7SahymxyuNB/Tb2WPFVIB7zRTvxT9EfUZyzUtFk1gTQ JpnfKwv0EHIK0y2Pltnb7/0yNbG0IAMg3Z1tRj+Aj4e97ric5fS+mGLXJ3TCNTc3OHMh 4V9zNsb5b1+XOE8YcqOZJ0OPJZtKJYKY1whXEaowshtinsGmIFKJGXtrKD+IoVd4clJt +vtA== X-Gm-Message-State: AOAM533x+yi+cSiS2mklcFxd9qYHOXQOBYnibjzibkxRUpUtChNZgwVo gMBbWXil5h3rugq/Uva8HR3N3QCLv476utcG X-Google-Smtp-Source: ABdhPJzKbrlBmq/TpdqOM3gollrTlr5so0MYSLgPialXtEsbtlzmBUP/XTfqustD6wHurs1xWKmxxQ== X-Received: by 2002:a0c:8304:: with SMTP id j4mr6725616qva.18.1614903791323; Thu, 04 Mar 2021 16:23:11 -0800 (PST) Received: from [192.168.0.189] (modemcable068.184-131-66.mc.videotron.ca. [66.131.184.68]) by smtp.gmail.com with ESMTPSA id o30sm707087qkl.17.2021.03.04.16.23.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Mar 2021 16:23:10 -0800 (PST) Subject: Re: [PATCH] pinctrl: qcom: lpass lpi: use default pullup/strength values To: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, Andy Gross , Linus Walleij , Srinivas Kandagatla , "open list:PIN CONTROL SUBSYSTEM" , open list References: <20210304194816.3843-1-jonathan@marek.ca> From: Jonathan Marek Message-ID: <4dca7cc0-4510-9093-b7d2-7d6ba23a09fc@marek.ca> Date: Thu, 4 Mar 2021 19:21:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/4/21 7:05 PM, Bjorn Andersson wrote: > On Thu 04 Mar 13:48 CST 2021, Jonathan Marek wrote: > >> If these fields are not set in dts, the driver will use these variables >> uninitialized to set the fields. Not only will it set garbage values for >> these fields, but it can overflow into other fields and break those. >> >> In the current sm8250 dts, the dmic01 entries do not have a pullup setting, >> and might not work without this change. >> > > Perhaps you didn't see it, but Dan reported this a few days back. So > unless you object I would suggest that we include: > I did not see it. But feel free to add tags. > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > > Reviewed-by: Bjorn Andersson > > Regards, > Bjorn > >> Fixes: 6e261d1090d6 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver") >> Signed-off-by: Jonathan Marek >> --- >> drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c >> index 369ee20a7ea95..2f19ab4db7208 100644 >> --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c >> +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c >> @@ -392,7 +392,7 @@ static int lpi_config_set(struct pinctrl_dev *pctldev, unsigned int group, >> unsigned long *configs, unsigned int nconfs) >> { >> struct lpi_pinctrl *pctrl = dev_get_drvdata(pctldev->dev); >> - unsigned int param, arg, pullup, strength; >> + unsigned int param, arg, pullup = LPI_GPIO_BIAS_DISABLE, strength = 2; >> bool value, output_enabled = false; >> const struct lpi_pingroup *g; >> unsigned long sval; >> -- >> 2.26.1 >>