From: Matthias Brugger <matthias.bgg@gmail.com>
To: sean.wang@mediatek.com, robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 03/12] arm: dts: mt7623: fix invalid memory node being generated
Date: Fri, 11 May 2018 17:03:22 +0200 [thread overview]
Message-ID: <4dcb0435-1f98-0753-0feb-d17ad02077ae@gmail.com> (raw)
In-Reply-To: <d887b72e1839c7e476179e384cfc712216096f20.1523434758.git.sean.wang@mediatek.com>
On 04/11/2018 10:53 AM, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> Below two wrong nodes in existing DTS files would cause a fail boot since
> in fact the address 0 is not the correct place the memory device locates
> at.
>
> memory {
> device_type = "memory";
> reg = <0x0 0x0 0x0 0x0>;
> };
>
> memory@80000000 {
> reg = <0x0 0x80000000 0x0 0x40000000>;
> };
>
> In order to avoid having a memory node starting at address 0, we can't
> include file skeleton64.dtsi and instead need to explicitly manually
> define a few of properties the DTS relies on such as #address-cells
> and #size-cells in root node and device_type in the node memory@80000000.
>
> Cc: stable@vger.kernel.org
> Fixes: 31ac0d69a1d4 ("ARM: dts: mediatek: add MT7623 basic support")
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> ---
> arch/arm/boot/dts/mt7623.dtsi | 3 ++-
> arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 1 +
> arch/arm/boot/dts/mt7623n-rfb.dtsi | 1 +
> 3 files changed, 4 insertions(+), 1 deletion(-)
>
merged. We would need this at least for mt2701 as well, correct?
Would you mind to provide a patch.
Regards,
Matthias
> diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
> index fec4715..406a9f3 100644
> --- a/arch/arm/boot/dts/mt7623.dtsi
> +++ b/arch/arm/boot/dts/mt7623.dtsi
> @@ -15,11 +15,12 @@
> #include <dt-bindings/phy/phy.h>
> #include <dt-bindings/reset/mt2701-resets.h>
> #include <dt-bindings/thermal/thermal.h>
> -#include "skeleton64.dtsi"
>
> / {
> compatible = "mediatek,mt7623";
> interrupt-parent = <&sysirq>;
> + #address-cells = <2>;
> + #size-cells = <2>;
>
> cpu_opp_table: opp-table {
> compatible = "operating-points-v2";
> diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> index bbf56f8..5938e4c 100644
> --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> @@ -109,6 +109,7 @@
> };
>
> memory@80000000 {
> + device_type = "memory";
> reg = <0 0x80000000 0 0x40000000>;
> };
> };
> diff --git a/arch/arm/boot/dts/mt7623n-rfb.dtsi b/arch/arm/boot/dts/mt7623n-rfb.dtsi
> index a199ae7..343e8ef 100644
> --- a/arch/arm/boot/dts/mt7623n-rfb.dtsi
> +++ b/arch/arm/boot/dts/mt7623n-rfb.dtsi
> @@ -40,6 +40,7 @@
> };
>
> memory@80000000 {
> + device_type = "memory";
> reg = <0 0x80000000 0 0x40000000>;
> };
>
>
next prev parent reply other threads:[~2018-05-11 15:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 8:53 [PATCH v2 00/12] refactor dts and add support for more boards sean.wang
2018-04-11 8:53 ` [PATCH v2 01/12] dt-bindings: cpufreq: mediatek: use - instead of _ in examples sean.wang
2018-05-02 8:59 ` Matthias Brugger
2018-04-11 8:53 ` [PATCH v2 02/12] arm: dts: mediatek: converted to using SPDX identifiers sean.wang
2018-04-11 8:53 ` [PATCH v2 03/12] arm: dts: mt7623: fix invalid memory node being generated sean.wang
2018-05-11 15:03 ` Matthias Brugger [this message]
2018-05-12 5:28 ` Sean Wang
2018-04-11 8:53 ` [PATCH v2 04/12] arm: dts: mt7623: fix available memory size on bananapi-r2 sean.wang
2018-04-11 8:53 ` [PATCH v2 05/12] arm: dts: mt7623: fix all Warnings (unit_address_vs_reg) sean.wang
2018-04-11 8:53 ` [PATCH v2 06/12] arm: dts: mt7623: add BTIF, HSDMA and SPI-NOR device nodes sean.wang
2018-04-11 8:54 ` [PATCH v2 07/12] arm: dts: mt6323: move node mt6323 leds to mt6323.dtsi sean.wang
2018-04-11 8:54 ` [PATCH v2 08/12] arm: dts: mediatek: modify audio related nodes for both MT2701 and MT7623 sean.wang
2018-04-11 8:54 ` [PATCH v2 09/12] arm: dts: mt7623: extend common file reused by all boards with MT7623 SoCs sean.wang
2018-04-11 8:54 ` [PATCH v2 10/12] arm: dts: mt7623: add MT7623A SoC level DTS sean.wang
2018-04-11 8:54 ` [PATCH v2 11/12] arm: dts: mt7623: add MT7623A reference boards sean.wang
2018-04-11 8:54 ` [PATCH v2 12/12] arm: dts: mt7623: add MT7623N reference board with eMMC sean.wang
2018-05-11 16:40 ` [PATCH v2 00/12] refactor dts and add support for more boards Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dcb0435-1f98-0753-0feb-d17ad02077ae@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).