From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35F9AC43457 for ; Sun, 18 Oct 2020 17:40:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED44522240 for ; Sun, 18 Oct 2020 17:40:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l6u3B8ph" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727155AbgJRRkF (ORCPT ); Sun, 18 Oct 2020 13:40:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbgJRRkF (ORCPT ); Sun, 18 Oct 2020 13:40:05 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF2B5C061755; Sun, 18 Oct 2020 10:40:04 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id d24so8690807ljg.10; Sun, 18 Oct 2020 10:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CZ5/1YNy2bWo7Jp+UxAXqknDLVCcYm3vq3FYtrYD/QY=; b=l6u3B8phZSYgy1V4b9FLJO+NLWfYJD3epja1Etg9m4quhshmTJ8GtBeaFevy9ziDsI hre+pYMJZAMuQJGksbOlWryhYW6ift3IyFD+jr62MCy7jZcBlYLRpP9qXsnZyriPdZgk UeaKIB8G1IblZxUp5pLoK9koCuDwC76n70rnFkbXKFMt7NKSdCIbS6OQROuESLAppTj6 hae4vXEZZce1WieTsDf2Jm64ea7vP28tcSslN4YevjMJj0gbI2zsPuKOMTrIRO5WsT/V rhgsrcAcvpyPLpjioSCsAn8OVFOyn2VA2Fs+szWw/u5O+fxe45XK2XayWb0Rq2U+MGg/ bspA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CZ5/1YNy2bWo7Jp+UxAXqknDLVCcYm3vq3FYtrYD/QY=; b=PSoPfbwi7H2YpBBHUnwkms+88JKHwYZJjBYeBbKb65hPav/Dw36YuaVTPQDsLHNnbL 0IwX5tTxf3/o5l1cx34N3i6fePfCtXngLXnuav3yUoA0nXlEKKm+/oK7hTVLoi8c8PLI vHN3/kJj0CDRW6W1XVd6aCYpOQ9sJj1HIizAL+10a4dp+fTOrZ2uHWTu74s6ZxlJ1WoY tTvyoBFl2kxrWbR3Ca+ouItzhZ8W+nDjFlj6b7HbQNGKnUPo2RnnVkGkEqBbjI/pIYdC RL2ogmF5+PLvEvBpRMDVdjEppZc2LqVLmwPBPMGPNc/ZK35Mbw8JHwX3YaSKQ6XngikR uQ+A== X-Gm-Message-State: AOAM530aJ1yXm+9ChYbi0hn4ODHJ6YtJ8SzUKv5CvzwtpYWUXLdsnmKD GY7lD7ueRRSzaj++f9zqlHqPUhO0vrpcOg== X-Google-Smtp-Source: ABdhPJxMUy/3JQXqufHrNfxcxp+8pLkSS1BbN7I5aOJx8L6RKPOrWgvCnIRR/6i3SGAyiXcKPsSTiQ== X-Received: by 2002:a2e:9c52:: with SMTP id t18mr4941259ljj.65.1603042803010; Sun, 18 Oct 2020 10:40:03 -0700 (PDT) Received: from ?IPv6:2a00:1fa0:42a2:d0b3:f3e9:8103:3101:8ef6? ([2a00:1fa0:42a2:d0b3:f3e9:8103:3101:8ef6]) by smtp.gmail.com with ESMTPSA id p26sm2900343lfd.262.2020.10.18.10.40.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Oct 2020 10:40:02 -0700 (PDT) Subject: Re: [PATCH v1] usb: dwc3: core: fix a issue about clear connect state To: Dejin Zheng , balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org References: <20201018134734.10406-1-zhengdejin5@gmail.com> From: Sergei Shtylyov Message-ID: <4dcdcdcf-2878-f6b1-e85a-6cb2a478ed1a@gmail.com> Date: Sun, 18 Oct 2020 20:40:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201018134734.10406-1-zhengdejin5@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 10/18/20 4:47 PM, Dejin Zheng wrote: > According to Synopsys Programming Guide chapter 2.2 Register Resets, > it cannot reset the DCTL register by set DCTL.CSFTRST for Core Soft Reset, s/set/setting/. > if DWC3 controller as a slave device and stay connected with a usb host, > then, reboot linux, it will fail to reinitialize dwc3 as a slave device s/reboot/while rebooting/. > when the DWC3 controller did not power off. because the connection status > is incorrect, so we also need clear DCTL.RUN_STOP bit for disable connect ^ to ^ ing > when do core soft reset. ^ ing > Fixes: f59dcab176293b6 ("usb: dwc3: core: improve reset sequence") > Signed-off-by: Dejin Zheng [...] MBR, Sergei