From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752699AbdLHRDw (ORCPT ); Fri, 8 Dec 2017 12:03:52 -0500 Received: from lelnx193.ext.ti.com ([198.47.27.77]:56923 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633AbdLHRDs (ORCPT ); Fri, 8 Dec 2017 12:03:48 -0500 Subject: Re: [PATCH AUTOSEL for 4.14 012/135] ASoC: cs42l56: Fix reset GPIO name in example DT binding To: Mark Brown , CC: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" References: <20171207154513.4154-1-alexander.levin@verizon.com> <20171207154513.4154-12-alexander.levin@verizon.com> <20171207172502.i65qs7mql3r5k5jx@sirena.org.uk> <20171207210258.eu4jggcs3fanxjfb@sasha-lappy> <20171208113610.GA7606@sirena.org.uk> From: "Andrew F. Davis" Message-ID: <4dd7e1fd-b7a9-2dfa-074d-de9056fbaeee@ti.com> Date: Fri, 8 Dec 2017 11:03:42 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171208113610.GA7606@sirena.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/08/2017 05:36 AM, Mark Brown wrote: > On Thu, Dec 07, 2017 at 09:03:01PM +0000, alexander.levin@verizon.com wrote: >> On Thu, Dec 07, 2017 at 05:25:02PM +0000, Mark Brown wrote: > >>> We shouldn't be getting into adding completely new DT properties in >>> stable backports like this. Old kernels have the bindings they have. > >> I thought that this one just adjust the example to match the code, and >> doesn't actually change anything? > > No, there's a corresponding code change - the changelog is badly written. > Not this patch, this one was just the example was wrong, the driver looks for, and always did look for, the "cirrus,gpio-nreset". Only the tlv* drivers looked for the other property and needed code changing, and those are separate patches.