From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754564AbeALHn4 convert rfc822-to-8bit (ORCPT + 1 other); Fri, 12 Jan 2018 02:43:56 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:39555 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754522AbeALHnz (ORCPT ); Fri, 12 Jan 2018 02:43:55 -0500 From: Loic PALLARDY To: Bjorn Andersson CC: "ohad@wizery.com" , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Arnaud POULIQUEN , "benjamin.gaignard@linaro.org" Subject: RE: [PATCH v2 02/16] remoteproc: add release ops in rproc_mem_entry struct Thread-Topic: [PATCH v2 02/16] remoteproc: add release ops in rproc_mem_entry struct Thread-Index: AQHTafre/1Q/67Jaw0+CAmbfLoG2QqNCAd6AgC4cOqA= Date: Fri, 12 Jan 2018 07:43:52 +0000 Message-ID: <4dfc381266dd4290a8e53c4074fe3ccb@SFHDAG7NODE2.st.com> References: <1512060411-729-1-git-send-email-loic.pallardy@st.com> <1512060411-729-3-git-send-email-loic.pallardy@st.com> <20171214003427.GD17344@builder> In-Reply-To: <20171214003427.GD17344@builder> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.50] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-12_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > -----Original Message----- > From: Bjorn Andersson [mailto:bjorn.andersson@linaro.org] > Sent: Thursday, December 14, 2017 1:34 AM > To: Loic PALLARDY > Cc: ohad@wizery.com; linux-remoteproc@vger.kernel.org; linux- > kernel@vger.kernel.org; Arnaud POULIQUEN ; > benjamin.gaignard@linaro.org > Subject: Re: [PATCH v2 02/16] remoteproc: add release ops in > rproc_mem_entry struct > > On Thu 30 Nov 08:46 PST 2017, Loic Pallardy wrote: > > > +static int rproc_release_carveout(struct rproc *rproc, struct > rproc_mem_entry *mem) > > +{ > > + struct device *dev = &rproc->dev; > > + > > + /* clean up carveout allocations */ > > + dma_free_coherent(dev->parent, mem->len, mem->va, mem- > >dma); > > + list_del(&mem->node); > > The core is responsible for putting the node on a list, so let the > cleanup take if off the list. ok > > > + kfree(mem); > > + return 0; > > +} > > + > [..] > > @@ -319,12 +322,11 @@ struct rproc_mem_entry { > > dma_addr_t dma; > > int len; > > u32 da; > > + int (*release)(struct rproc *rproc, struct rproc_mem_entry *mem); > > The placement here seems random, please move it last in the struct. ok > > > void *priv; > > struct list_head node; > > }; > > > > Regards, > Bjorn