From: ascordeiro <alinesantanacordeiro@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: media: omap4iss: Remove unused macro functions
Date: Tue, 13 Apr 2021 15:21:35 -0300 [thread overview]
Message-ID: <4e2f52124b29b3ed6c3f7f645f067c503c7cf4cf.camel@gmail.com> (raw)
In-Reply-To: <03549d0e-04d9-6d37-93e3-c09b29ce53aa@xs4all.nl>
Em ter, 2021-04-13 às 17:06 +0200, Hans Verkuil escreveu:
> On 12/04/2021 15:42, Aline Santana Cordeiro wrote:
> > Remove unused macro functions "to_iss_device()", "to_device()",
> > and "v4l2_dev_to_iss_device(dev)".
>
> 'git grep to_iss_device drivers/staging/omap4iss' gives me lots of
> hits!
> Same for to_device. Only v4l2_dev_to_iss_device appears to be unused.
>
> Regards,
>
> Hans
>
This command is really helpful, I didin't know.
Thank you for the tip.
May I send a v2 removing just v4l2_dev_to_iss_device?
Thank you in advance,
Aline
> >
> > Signed-off-by: Aline Santana Cordeiro <
> > alinesantanacordeiro@gmail.com>
> > ---
> > drivers/staging/media/omap4iss/iss.h | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/drivers/staging/media/omap4iss/iss.h
> > b/drivers/staging/media/omap4iss/iss.h
> > index b88f952..a354d5f 100644
> > --- a/drivers/staging/media/omap4iss/iss.h
> > +++ b/drivers/staging/media/omap4iss/iss.h
> > @@ -29,11 +29,6 @@
> >
> > struct regmap;
> >
> > -#define to_iss_device(ptr_module) \
> > - container_of(ptr_module, struct iss_device, ptr_module)
> > -#define
> > to_device(ptr_module) \
> > - (to_iss_device(ptr_module)->dev)
> > -
> > enum iss_mem_resources {
> > OMAP4_ISS_MEM_TOP,
> > OMAP4_ISS_MEM_CSI2_A_REGS1,
> > @@ -119,9 +114,6 @@ struct iss_device {
> > unsigned int isp_subclk_resources;
> > };
> >
> > -#define v4l2_dev_to_iss_device(dev) \
> > - container_of(dev, struct iss_device, v4l2_dev)
> > -
> > int omap4iss_get_external_info(struct iss_pipeline *pipe,
> > struct media_link *link);
> >
> >
>
next prev parent reply other threads:[~2021-04-13 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 13:42 [PATCH] staging: media: omap4iss: Remove unused macro functions Aline Santana Cordeiro
2021-04-12 18:08 ` kernel test robot
2021-04-13 15:06 ` Hans Verkuil
2021-04-13 18:21 ` ascordeiro [this message]
2021-04-14 8:02 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e2f52124b29b3ed6c3f7f645f067c503c7cf4cf.camel@gmail.com \
--to=alinesantanacordeiro@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).