From: Joe Perches <joe@perches.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vim: linux-kernel: Increase columns highlighting to 100+
Date: Fri, 31 Jul 2020 09:35:42 -0700 [thread overview]
Message-ID: <4e30e2df7bec0fedf1a29f7825fbb4c12593eac9.camel@perches.com> (raw)
In-Reply-To: <20200731163301.GA8004@embeddedor>
On Fri, 2020-07-31 at 11:33 -0500, Gustavo A. R. Silva wrote:
> Increase columns highlighting to 100+ once the 80-column warning has
> been deprecated in the Linux kernel[1].
>
> [1] commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> plugin/linuxsty.vim | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/plugin/linuxsty.vim b/plugin/linuxsty.vim
> index 6f7e331..c42ce72 100644
> --- a/plugin/linuxsty.vim
> +++ b/plugin/linuxsty.vim
> @@ -62,7 +62,7 @@ function s:LinuxFormatting()
> setlocal tabstop=8
> setlocal shiftwidth=8
> setlocal softtabstop=8
> - setlocal textwidth=80
> + setlocal textwidth=100
This is not a good change.
80 columns is still _preferred_.
It's just checkpatch will not emit a warning
for lines longer than 80 columns but will
for lines longer than 100 columns.
checkpatch will also not emit a warning on
file checking at all.
> setlocal noexpandtab
>
> setlocal cindent
> @@ -80,7 +80,7 @@ function s:LinuxHighlighting()
> highlight default link LinuxError ErrorMsg
>
> syn match LinuxError / \+\ze\t/ " spaces before tab
> - syn match LinuxError /\%>80v[^()\{\}\[\]<>]\+/ " virtual column 81 and more
> + syn match LinuxError /\%>100v[^()\{\}\[\]<>]\+/ " virtual column 101 and more
>
> " Highlight trailing whitespace, unless we're in insert mode and the
> " cursor's placed right after the whitespace. This prevents us from having
next prev parent reply other threads:[~2020-07-31 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 16:33 [PATCH] vim: linux-kernel: Increase columns highlighting to 100+ Gustavo A. R. Silva
2020-07-31 16:35 ` Joe Perches [this message]
2020-07-31 17:07 ` Gustavo A. R. Silva
2020-07-31 17:17 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2020-07-31 16:30 Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e30e2df7bec0fedf1a29f7825fbb4c12593eac9.camel@perches.com \
--to=joe@perches.com \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).