From: "gaochao (L)" <gaochao49@huawei.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Sean Paul <seanpaul@chromium.org>, <zhengbin13@huawei.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m
Date: Tue, 24 May 2022 10:27:32 +0800 [thread overview]
Message-ID: <4e513db6-6b42-0b86-d0ed-fac762d9c746@huawei.com> (raw)
In-Reply-To: <CAD=FV=VVZo+wsR0yPLvq-8jkZg12+Sw0NM0TkgQLHDCxCiFdGw@mail.gmail.com>
在 2022/5/24 0:47, Doug Anderson 写道:
> Hi,
>
> On Mon, May 23, 2022 at 1:58 AM gaochao <gaochao49@huawei.com> wrote:
>>
>> If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m,
>> bulding fails:
>>
>> drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function `atana33xc20_probe':
>> panel-samsung-atna33xc20.c:(.text+0x744): undefined reference to
>> `drm_panel_dp_aux_backlight'
>> make: *** [vmlinux] Error 1
>>
>> Let CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 select DRM_DISPLAY_DP_HELPER and
>> CONFIG_DRM_DISPLAY_HELPER to fix this error.
>>
>> Fixes: 32ce3b320343 ("drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: gaochao <gaochao49@huawei.com>
>
> I think the author / Signed-off-by are supposed to be real names. Is
> "gaochao" your legal name?
Thank you for the review.
Should be "Gao Chao", fixing in the second version.
>
>> ---
>> drivers/gpu/drm/panel/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>
> Other than the Signed-off-by / Author issue:
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> .
next prev parent reply other threads:[~2022-05-24 2:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 8:57 [PATCH -next] drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m gaochao
2022-05-23 16:47 ` Doug Anderson
2022-05-24 2:27 ` gaochao (L) [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-05-23 6:06 gaochao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e513db6-6b42-0b86-d0ed-fac762d9c746@huawei.com \
--to=gaochao49@huawei.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=seanpaul@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).