Re: fw_fallback.sh test failed in Debian 11

From: Russ Weight <russell.h.weight@intel.com>
To: "Zhou, Jie2X" <jie2x.zhou@intel.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "shuah@kernel.org" <shuah@kernel.org>,
	"mcgrof@kernel.org" <mcgrof@kernel.org>,
	"Zhang, Tianfei" <tianfei.zhang@intel.com>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Li, Philip" <philip.li@intel.com>
Subject: Re: fw_fallback.sh test failed in Debian 11
Date: Fri, 2 Dec 2022 08:29:15 -0800	[thread overview]
Message-ID: <4e5bbaf8-58ea-5ebe-a585-496ee7b51bce@intel.com> (raw)
In-Reply-To: <CY4PR11MB132068A19AF9704D1B14814FC5179@CY4PR11MB1320.namprd11.prod.outlook.com>

On 12/1/22 22:02, Zhou, Jie2X wrote:
>> The above message looks like the problem. Firmware sysfs fallback has been turned off
>> on this system using sysctl. Can you try turning it on and rerunning the test?
> Sorry, I don't know how to turn on firmware sysfs fallback.
> Could you tell me?

Take a look at the kernel documentation (https://www.kernel.org/doc/html/v5.0/driver-api/firmware/fallback-mechanisms.html) which says, "This syfs fallback mechanism may be disabled completely on a system by setting the proc sysctl value ignore_sysfs_fallback to true."

Also refer to the sysctl man page: https://manpages.debian.org/testing/procps/sysctl.8.en.html.

- Russ

>
> I search the firmware fallback options in kernel config.
> CONFIG_FW_LOADER_USER_HELPER=y
> # CONFIG_FW_LOADER_USER_HELPER_FALLBACK is not set
>
> best regards,
>
> ________________________________________
> From: Weight, Russell H <russell.h.weight@intel.com>
> Sent: Thursday, December 1, 2022 10:37 AM
> To: Zhou, Jie2X; gregkh@linuxfoundation.org
> Cc: shuah@kernel.org; mcgrof@kernel.org; Zhang, Tianfei; linux-kselftest@vger.kernel.org; linux-kernel@vger.kernel.org; Li, Philip
> Subject: Re: fw_fallback.sh test failed in Debian 11
>
>
>
> On 11/30/22 17:28, Zhou, Jie2X wrote:
>>> How much of this path exists on your machine?
>>> /sys/devices/virtual/misc/test_firmware/trigger_request
>> This path exists.
>>
>>> And is there anything in the dmesg output that indicates a failure associated with
>>> the test_firmware device?
>> Yes.
>>
>> kern  :info  : [   77.858068] test_firmware: loading 'test-firmware.bin'
>> kern  :info  : [   77.864705] test_firmware: loaded: 8
>> kern  :info  : [   77.874250] test_firmware: loading 'test-firmware.bin'
>> kern  :warn  : [   77.880672] misc test_firmware: Direct firmware load for test-firmware.bin failed with error -2
>> kern  :info  : [   77.890106] test_firmware: load of 'test-firmware.bin' failed: -2
>> kern  :info  : [   78.896662] test_firmware: loading ''
>> kern  :info  : [   78.901059] test_firmware: load of '' failed: -22
>> kern  :info  : [   78.907422] test_firmware: loading ''
>> kern  :err   : [   78.912278] test_firmware: failed to async load firmware
>> kern  :info  : [   78.918594] test_firmware: loading 'nope-test-firmware.bin'
>> kern  :warn  : [   78.925405] misc test_firmware: Direct firmware load for nope-test-firmware.bin failed with error -2
>> kern  :info  : [   78.935260] Ignoring firmware sysfs fallback due to sysctl knob
> The above message looks like the problem. Firmware sysfs fallback has been turned off
> on this system using sysctl. Can you try turning it on and rerunning the test?
>
> Thanks,
> - Russ
>
>> kern  :info  : [   78.941934] test_firmware: load of 'nope-test-firmware.bin' failed: -2
>> kern  :info  : [   78.962155] test_firmware: loading 'test-firmware.bin'
>> kern  :info  : [   78.968232] test_firmware: loaded: 9
>> kern  :info  : [   78.986063] test_firmware: loading 'test-firmware.bin'
>> kern  :info  : [   78.992269] test_firmware: loaded: 9
>> kern  :info  : [   79.023611] test_firmware: reset
>> kern  :info  : [   79.028466] test_firmware: batched sync firmware loading 'test-firmware.bin' 4 times
>>
>> best regards,