From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Jonathan Marek <jonathan@marek.ca>, Rob Herring <robh@kernel.org>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, David Airlie <airlied@linux.ie>,
freedreno@lists.freedesktop.org,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVER FOR MSM ADRENO GPU"
<dri-devel@lists.freedesktop.org>,
Rob Clark <robdclark@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
"open list:DRM DRIVER FOR MSM ADRENO GPU"
<linux-arm-msm@vger.kernel.org>, Sean Paul <sean@poorly.run>
Subject: Re: [Freedreno] [PATCH v2 2/2] dt-bindings: display: msm/dsi: add qcom, dsi-phy-cphy-mode option
Date: Mon, 31 May 2021 21:10:19 +0300 [thread overview]
Message-ID: <4e623554-bbe4-4d4a-7b14-0ca4f684c7fb@linaro.org> (raw)
In-Reply-To: <0e083e31-d349-6d5c-048f-258414492b2c@marek.ca>
On 28/05/2021 15:57, Jonathan Marek wrote:
> On 5/3/21 1:11 PM, Rob Herring wrote:
>> On Fri, Apr 23, 2021 at 01:24:40PM -0400, Jonathan Marek wrote:
>>> Document qcom,dsi-phy-cphy-mode option, which can be used to control
>>> whether DSI will operate in D-PHY (default) or C-PHY mode.
>>
>> Given this is a standard MIPI thing, I think this needs to be a common
>> property. We already have phy bindings that use the phy cells to set the
>> phy type which I think you should use here. See
>> include/dt-bindings/phy/phy.h.
>>
>
> Is it OK to simply change the option to something like "phy-mode =
> <PHY_TYPE_DSI_CPHY>;"?
>
> (using phy-cells would be annoying to implement, with no benefit IMO)
To add another feather to the balance scales:
- `phys = <&dsi0_phy PHY_TYPE_DSI_CPHY>;` would bring knowledge about
PHY mode to the DSI host (which does not really care about PHY mode)
- `phy-mode = <PHY_TYPE_DSI_CPHY>;` would stay in the PHY node, where
this information belongs.
--
With best wishes
Dmitry
prev parent reply other threads:[~2021-05-31 18:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 17:24 [PATCH v2 0/2] drm/msm/dsi: support CPHY mode for 7nm pll/phy Jonathan Marek
2021-04-23 17:24 ` [PATCH v2 1/2] " Jonathan Marek
2021-04-24 14:27 ` Dmitry Baryshkov
2021-04-23 17:24 ` [PATCH v2 2/2] dt-bindings: display: msm/dsi: add qcom,dsi-phy-cphy-mode option Jonathan Marek
2021-05-03 17:11 ` Rob Herring
2021-05-28 12:57 ` [Freedreno] [PATCH v2 2/2] dt-bindings: display: msm/dsi: add qcom, dsi-phy-cphy-mode option Jonathan Marek
2021-05-31 18:10 ` Dmitry Baryshkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e623554-bbe4-4d4a-7b14-0ca4f684c7fb@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).