From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753554AbcFBQZZ (ORCPT <rfc822;w@1wt.eu>);
	Thu, 2 Jun 2016 12:25:25 -0400
Received: from mail-pf0-f171.google.com ([209.85.192.171]:36111 "EHLO
	mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751360AbcFBQZY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 2 Jun 2016 12:25:24 -0400
Subject: Re: [PATCH 01/32] arm64: Add platform selection for BCM2835.
To: Gerd Hoffmann <kraxel@redhat.com>, Florian Fainelli <f.fainelli@gmail.com>
References: <1464817421-8519-1-git-send-email-kraxel@redhat.com>
 <1464817421-8519-2-git-send-email-kraxel@redhat.com>
 <574F5881.4060008@gmail.com> <1464849936.24775.33.camel@redhat.com>
Cc: linux-rpi-kernel@lists.infradead.org, Eric Anholt <eric@anholt.net>,
        Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>,
        Russell King <linux@armlinux.org.uk>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        "open list:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." 
	<bcm-kernel-feedback-list@broadcom.com>,
        "moderated list:ARM SUB-ARCHITECTURES" 
	<linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
From: Ray Jui <ray.jui@broadcom.com>
Message-ID: <4e72ae37-a018-a17d-6a58-8450db58d1c7@broadcom.com>
Date: Thu, 2 Jun 2016 09:25:17 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2
MIME-Version: 1.0
In-Reply-To: <1464849936.24775.33.camel@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 6/1/2016 11:45 PM, Gerd Hoffmann wrote:
>>>  config ARCH_BCM2835
>>>  	bool "Broadcom BCM2835 family"
>>> -	depends on ARCH_MULTI_V6 || ARCH_MULTI_V7
>>> +	depends on ARCH_MULTI_V6 || ARCH_MULTI_V7 || ARM64
>>
>> Humm, what does that achieve?
>
> Nothing ;)
>
> Slipped through unnoticed, I'll drop it.
>
>>> +config ARCH_BCM
>>> +	bool "Broadcom SoC Support"
>>> +	help
>>> +	  This enables support for Broadcom ARM based SoC chips
>>
>> menuconfig maybe?
>
> There isn't any in arch/arm64/Kconfig.platforms right now, so I didn't
> feel like introducing one.  Also the dependency should have pretty much
> the same effect ...
>
>>> +config ARCH_BCM2835
>>> +	bool "Broadcom BCM2835 family"
>>> +	depends on ARCH_BCM
>>> +	select ARCH_REQUIRE_GPIOLIB
>>> +	select CLKSRC_OF
>>> +	select PINCTRL
>>> +	select PINCTRL_BCM2835
>>> +	select ARM_AMBA
>>> +	select ARM_TIMER_SP804
>>> +	select HAVE_ARM_ARCH_TIMER
>>> +	help
>>> +	  This enables support for the Broadcom BCM2837 SoC.
>>> +	  This SoC is used in the Raspberry Pi 3 device.
>>> +
>>>  config ARCH_BCM_IPROC
>>>  	bool "Broadcom iProc SoC Family"
>>> +	depends on ARCH_BCM
>>
>> Does not seem necessary nor adding anything here.
>
> Added for consistency.  When we add ARCH_BCM all ARCH_BCM_* should
> depend on it ...
>
> We could also do it the other way around: make ARCH_BCM a hidden bool
> and have ARCH_BCM_* select it.

Yes, this is probably better.

ARCH_BCM_IPROC is currently enabled in arch/arm64/configs/defconfig. By 
adding a dependency here without enabling ARCH_BCM in arm64 defconfig, 
this effectively disables ARCH_BCM_IPROC from arm64 defconfig.

>
> cheers,
>   Gerd
>