From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9591CC2D0C0 for ; Fri, 6 Dec 2019 07:49:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6AC3F24680 for ; Fri, 6 Dec 2019 07:49:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="cnxkcM2z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726598AbfLFHtZ (ORCPT ); Fri, 6 Dec 2019 02:49:25 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:47083 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726184AbfLFHtY (ORCPT ); Fri, 6 Dec 2019 02:49:24 -0500 Received: by mail-lf1-f68.google.com with SMTP id f15so3707133lfl.13 for ; Thu, 05 Dec 2019 23:49:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kmy/hqtYsjJdqSxe1RXY3ysFVnTDOWj+4UzNeSbXyQ0=; b=cnxkcM2zBCw501wJ8H5ubD377z1l0CWx0Em/20T7JYyuEYICO/QR0xiCDpWHlSqXCt JjWLfxgjwWgB54GyOzKMnLh1bB6nsh4ImXgzI1MeSR4Di1aNIVrjKE/cS51QrcznZZ1W JkjfcBgRrm+7vlzN5nXW89Na8ZWKr3ivSkAfc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kmy/hqtYsjJdqSxe1RXY3ysFVnTDOWj+4UzNeSbXyQ0=; b=HKh+64fEaE6zeNvU3MUIyJrhTZAnU7m7HO4GpYrGn/ZE0dqvEH5Hn+gcf/fbfMJsel DjF6pzQwesNVaUnaZG1MIb7lsCgW4Ehtz9h8CHPvPeHp6RbsDXKNyzep9U2nKOJOm4as /KVlMlFk9wVkrZw8Pr6DrD/98Lf/tWvlX/PmVY+oEWmxv46Vv7N3o+V4M/enKvSOyZYf Sfehl/8O0HdGJWKM6LSq4DxA1rCL58UMRG6W/nGbUOItEzI3rPV0yesrYVTOcnSNYz4A l9NguGuHwFsY3Xbrz6zwvF20F+uVWXQdt+GRYgnV51mumLpKsPAvB2xUVY1hjBVb6k0e ImKw== X-Gm-Message-State: APjAAAXev+PNkCPIE0eywQwwb2kxdXeeip7/qHNO2ZF2cqMOFL3Tv3LM ZouXVNwQ3IwuBA974WGMflWSzeEHkDwv9I9m X-Google-Smtp-Source: APXvYqzWK9nbn2UUY59BW9P/8Slwo/2W/+Hi1HaS8kg5zC9iRhpU7XfAl0CMdm/YK0/eeVy3i4vXKg== X-Received: by 2002:a19:f80a:: with SMTP id a10mr7621557lff.107.1575618562000; Thu, 05 Dec 2019 23:49:22 -0800 (PST) Received: from [172.16.11.28] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id g85sm6094899lfd.66.2019.12.05.23.49.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Dec 2019 23:49:21 -0800 (PST) Subject: Re: [PATCH 17/18] dyndbg: rename dynamic_debug to dyndbg To: Andy Shevchenko , Jim Cromie Cc: jbaron@akamai.com, Greg Kroah-Hartman , Linux Kernel Mailing List , Jonathan Corbet , Andrew Morton , Kees Cook , Masahiro Yamada , "David S. Miller" , Joe Lawrence , Kent Overstreet , "Uladzislau Rezki (Sony)" , Andy Shevchenko , Gary Hook , Arnd Bergmann , Mark Rutland , Linux Documentation List References: <20191205215151.421926-1-jim.cromie@gmail.com> <20191205215151.421926-20-jim.cromie@gmail.com> From: Rasmus Villemoes Message-ID: <4e758f68-f1f3-432b-7bc0-2691012ec831@rasmusvillemoes.dk> Date: Fri, 6 Dec 2019 08:49:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/12/2019 23.24, Andy Shevchenko wrote: > On Thu, Dec 5, 2019 at 11:54 PM Jim Cromie wrote: >> >> This rename fixes a subtle usage wrinkle; the __setup() names didn't >> match the fake "dyndbg" module parameter used to enable dynamic-printk >> callsites in modules. See the last change in Docs for the effect. >> >> It also shortens the "__FILE__:__func__" prefix in dyndbg.verbose >> messages, effectively s/dynamic_debug/dyndbg/ >> >> This is a 99.9% rename; trim_prefix and debugfs_create_dir arg excepted. >> Nonetheless, it also changes both /sys appearances: >> >> bash-5.0# ls -R /sys/kernel/debug/dyndbg/ /sys/module/dyndbg/parameters/ >> /sys/kernel/debug/dyndbg/: >> control > >> /sys/module/dyndbg/parameters/: > > Isn't this path a part of ABI? Yeah, I think this is a somewhat dangerous change, and I don't really see the point. Unrelated: Jim, if you want these patches picked up eventually, you have to put akpm on the recipient list (he is on this one, but AFAICT not on any of the others). Rasmus