linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH linux dev-5.15] hwmon: (pmbus) modify PSU fan_target convert value to false
@ 2022-01-25 13:01 krishnar4
  2022-01-25 14:46 ` Guenter Roeck
  0 siblings, 1 reply; 4+ messages in thread
From: krishnar4 @ 2022-01-25 13:01 UTC (permalink / raw)
  To: Bartosz Golaszewski, Joel Stanley, Andrew Jeffery, Linus Walleij
  Cc: krishnar4, linux-hwmon, linux-arm-kernel, linux-aspeed,
	Deepak Kodihalli, Shakeeb Pasha, Vinodhini J, Pravinash Jeyapaul,
	linux-kernel

Description: PSU can't use sysfs fan_target to control PSU fan duty.

Signed-off-by: krishnar4 <krishnar@ami.com>
---
 drivers/hwmon/pmbus/pmbus_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index 776ee2237be2..a56c2e1c4079 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -1889,7 +1889,7 @@ static int pmbus_add_fan_ctrl(struct i2c_client *client,
 
 	sensor = pmbus_add_sensor(data, "fan", "target", index, page,
 				  0xff, PMBUS_VIRT_FAN_TARGET_1 + id, PSC_FAN,
-				  false, false, true);
+				  false, false, false);
 
 	if (!sensor)
 		return -ENOMEM;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH linux dev-5.15] hwmon: (pmbus) modify PSU fan_target convert value to false
  2022-01-25 13:01 [PATCH linux dev-5.15] hwmon: (pmbus) modify PSU fan_target convert value to false krishnar4
@ 2022-01-25 14:46 ` Guenter Roeck
  0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2022-01-25 14:46 UTC (permalink / raw)
  To: krishnar4, Bartosz Golaszewski, Joel Stanley, Andrew Jeffery,
	Linus Walleij
  Cc: linux-hwmon, linux-arm-kernel, linux-aspeed, Deepak Kodihalli,
	Shakeeb Pasha, Vinodhini J, Pravinash Jeyapaul, linux-kernel

On 1/25/22 05:01, krishnar4 wrote:
> Description: PSU can't use sysfs fan_target to control PSU fan duty.
> 

This is neither a proper subject nor a proper description.
"modify PSU fan_target convert value to false" means that the
value reported from the attribute is used directly without
conversion. The subject should reflect this.
"Description:" should not be part of the description, and
the description should describe the reason for the change
(ie explain clearly what is wrong).
"PSU can't use sysfs fan_target to control PSU fan duty"
doesn't explain anything and doesn't match the subject.

> Signed-off-by: krishnar4 <krishnar@ami.com>

"krishnar4" is not an acceptable name. This needs to be a real name.

Guenter

> ---
>   drivers/hwmon/pmbus/pmbus_core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
> index 776ee2237be2..a56c2e1c4079 100644
> --- a/drivers/hwmon/pmbus/pmbus_core.c
> +++ b/drivers/hwmon/pmbus/pmbus_core.c
> @@ -1889,7 +1889,7 @@ static int pmbus_add_fan_ctrl(struct i2c_client *client,
>   
>   	sensor = pmbus_add_sensor(data, "fan", "target", index, page,
>   				  0xff, PMBUS_VIRT_FAN_TARGET_1 + id, PSC_FAN,
> -				  false, false, true);
> +				  false, false, false);
>   
>   	if (!sensor)
>   		return -ENOMEM;


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH linux dev-5.15] hwmon: (pmbus) modify PSU fan_target convert value to false
       [not found] <git-send-email-krishnar@ami.com>
  2022-01-27  5:39 ` krishnar4
@ 2022-01-27  6:04 ` krishnar4
  1 sibling, 0 replies; 4+ messages in thread
From: krishnar4 @ 2022-01-27  6:04 UTC (permalink / raw)
  To: Bartosz Golaszewski, Joel Stanley, Andrew Jeffery, Linus Walleij
  Cc: linux-hwmon, linux-arm-kernel, linux-aspeed, Deepak Kodihalli,
	Vinodhini J, Pravinash Jeyapaul, Krishna Raj, linux-kernel,
	Shakeeb Pasha

Description: PSU can't use sysfs fan_target to control PSU fan duty.

Signed-off-by: krishnar4 <krishnar@ami.com>
---
 drivers/hwmon/pmbus/pmbus_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index 776ee2237be2..a56c2e1c4079 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -1889,7 +1889,7 @@ static int pmbus_add_fan_ctrl(struct i2c_client *client,
 
 	sensor = pmbus_add_sensor(data, "fan", "target", index, page,
 				  0xff, PMBUS_VIRT_FAN_TARGET_1 + id, PSC_FAN,
-				  false, false, true);
+				  false, false, false);
 
 	if (!sensor)
 		return -ENOMEM;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH linux dev-5.15] hwmon: (pmbus) modify PSU fan_target convert value to false
       [not found] <git-send-email-krishnar@ami.com>
@ 2022-01-27  5:39 ` krishnar4
  2022-01-27  6:04 ` krishnar4
  1 sibling, 0 replies; 4+ messages in thread
From: krishnar4 @ 2022-01-27  5:39 UTC (permalink / raw)
  To: Krishna Raj, Bartosz Golaszewski, Joel Stanley, Andrew Jeffery,
	Linus Walleij
  Cc: linux-hwmon, linux-arm-kernel, linux-aspeed, Deepak Kodihalli,
	Shakeeb Pasha, Vinodhini J, Pravinash Jeyapaul, linux-kernel

Description: PSU can't use sysfs fan_target to control PSU fan duty.

Signed-off-by: krishnar4 <krishnar@ami.com>
---
 drivers/hwmon/pmbus/pmbus_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index 776ee2237be2..a56c2e1c4079 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -1889,7 +1889,7 @@ static int pmbus_add_fan_ctrl(struct i2c_client *client,
 
 	sensor = pmbus_add_sensor(data, "fan", "target", index, page,
 				  0xff, PMBUS_VIRT_FAN_TARGET_1 + id, PSC_FAN,
-				  false, false, true);
+				  false, false, false);
 
 	if (!sensor)
 		return -ENOMEM;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-27  6:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-25 13:01 [PATCH linux dev-5.15] hwmon: (pmbus) modify PSU fan_target convert value to false krishnar4
2022-01-25 14:46 ` Guenter Roeck
     [not found] <git-send-email-krishnar@ami.com>
2022-01-27  5:39 ` krishnar4
2022-01-27  6:04 ` krishnar4

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).