From: Jon Hunter <jonathanh@nvidia.com>
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>
Cc: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
Curtis Malainey <cujomalainey@google.com>,
<linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] ASoC: soc-core: Fix probe deferral following prelink failure
Date: Mon, 1 Apr 2019 13:22:09 +0100 [thread overview]
Message-ID: <4eb94b41-7e16-7b39-5c14-a7d180ce67df@nvidia.com> (raw)
In-Reply-To: <1551706274-22571-1-git-send-email-jonathanh@nvidia.com>
Hi Mark,
On 04/03/2019 13:31, Jon Hunter wrote:
> From: Jonathan Hunter <jonathanh@nvidia.com>
>
> Commit 78a24e10cd94 ("ASoC: soc-core: clear platform pointers on error")
> re-worked the clean-up of any platform pointers that may have been
> initialised by the function snd_soc_init_platform(). This commit missed
> one error path where if any of the prelinks for a soundcard failed to
> initialise, then these platform pointers would not be cleaned-up. This
> then prevents the soundcard from being initialised following a probe
> deferral when any of the soundcard prelinks cannot be found.
>
> Fix this by ensuring that soc_cleanup_platform() is called when
> initialising the soundcard prelinks fails.
>
> Fixes: 78a24e10cd94 ("ASoC: soc-core: clear platform pointers on error")
>
> Signed-off-by: Jonathan Hunter <jonathanh@nvidia.com>
FYI, I am seeing that the deferral of soundcards failing with v5.1-rc3
because the above has not been merged yet. Just wanted to let you know
in case this one was not marked for v5.1.
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2019-04-01 12:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 13:31 [PATCH] ASoC: soc-core: Fix probe deferral following prelink failure Jon Hunter
2019-03-04 15:32 ` Applied "ASoC: soc-core: Fix probe deferral following prelink failure" to the asoc tree Mark Brown
2019-04-01 12:22 ` Jon Hunter [this message]
2019-04-02 4:35 ` [PATCH] ASoC: soc-core: Fix probe deferral following prelink failure Mark Brown
2019-04-02 8:52 ` Jon Hunter
2019-04-02 9:19 ` Mark Brown
2019-04-02 9:30 ` Jon Hunter
2019-04-02 9:31 ` Mark Brown
2019-04-02 9:44 ` Jon Hunter
2019-04-03 3:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4eb94b41-7e16-7b39-5c14-a7d180ce67df@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cujomalainey@google.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).