From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11443C07E95 for ; Tue, 13 Jul 2021 12:50:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E87C861289 for ; Tue, 13 Jul 2021 12:50:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236276AbhGMMxb (ORCPT ); Tue, 13 Jul 2021 08:53:31 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:15009 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236135AbhGMMxa (ORCPT ); Tue, 13 Jul 2021 08:53:30 -0400 Received: from dggeme703-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4GPL4p2P4szbbyh; Tue, 13 Jul 2021 20:47:22 +0800 (CST) Received: from [10.174.178.125] (10.174.178.125) by dggeme703-chm.china.huawei.com (10.1.199.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 13 Jul 2021 20:50:38 +0800 Subject: Re: [PATCH 5/5] mm/vmscan: fix misleading comment in isolate_lru_pages() To: Michal Hocko CC: , , , , , , , , , , , , , References: <20210710100329.49174-1-linmiaohe@huawei.com> <20210710100329.49174-6-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <4ecacfca-4aba-b2c2-bc61-56a7a5d0fb2b@huawei.com> Date: Tue, 13 Jul 2021 20:50:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.125] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggeme703-chm.china.huawei.com (10.1.199.99) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/7/13 17:32, Michal Hocko wrote: > On Mon 12-07-21 19:16:47, Miaohe Lin wrote: >> On 2021/7/12 15:28, Michal Hocko wrote: >>> On Sat 10-07-21 18:03:29, Miaohe Lin wrote: >>>> We couldn't know whether the page is being freed elsewhere until we failed >>>> to increase the page count. >>> >>> This is moving a hard to understand comment from one place to another. >> >> If get_page_unless_zero failed, the page could have been freed elsewhere. I think >> this looks straightforward but doesn't help a lot. Are you preferring to just >> remove this comment ? > > Yes the comment in its current form is not really helpful much. Does it > deserve a single liner to drop it? Likely not on its own without more > changes in that area. Sure, I will drop this single patch. And I would send a new patch when I collect enough misleading/obsolete comments to fix. Thanks. >