From: Marc Vertes <marc.vertes@sigfox.com>
To: w.sang@pengutronix.de, broonie@opensource.wolfsonmicro.com
Cc: Wim@vger.kernel.org, wim@iguana.be, Welte@vger.kernel.org,
Van@vger.kernel.org, Sebroeck@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
HaraldWelte@viatech.com, Harald@vger.kernel.org
Subject: Re: [PATCH RFC] watchdog: add a new driver for VIA chipsets
Date: Wed, 23 Nov 2011 10:59:12 +0100 [thread overview]
Message-ID: <4eccc3f0.iApQ//mCzaN3UsrB%marc.vertes@sigfox.com> (raw)
In-Reply-To: <20111122184051.GA30941@pengutronix.de>
Wolfram Sang <w.sang@pengutronix.de> wrote:
> On Tue, Nov 22, 2011 at 05:32:28PM +0000, Mark Brown wrote:
> > On Tue, Nov 22, 2011 at 06:05:48PM +0100, Marc Vertes wrote:
> >
> > > +static int wdt_start(struct watchdog_device *wdev)
> > > +{
> > > + /* Nothing to do. The watchdog can only be started by the BIOS. */
> > > + return 0;
> > > +}
> >
> > Shouldn't we just update the framework to cope with missing functions?
>
> For start(), I dunno. I don't have enough experience with watchdog drivers to
> judge if this is acceptable, although I'd think so. For stop(), a few drivers
> already activate a timer to keep the watchdog happy; such a mechanism should
> definately go into the core. It's in my todo-list, but I won't be angry if
> someone is faster ;)
A question regarding "nowayout", in the case of this VIA chipset where
a watchdog can not be stopped once started from BIOS. I think I should
set unconditionally WDOG_NO_WAY_OUT in status, shouldn't I ?
I also do not think it is correct to implement a timer and ping
proactively in case of magicclose because 1) it complicates a bit the
code, 2) there is no way to know the timeout value, and it set very low
in the BIOS (1 s).
Regards,
--
Marc
next prev parent reply other threads:[~2011-11-23 9:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 11:17 [PATCH RFC] watchdog: add a new driver for VIA chipsets Marc Vertes
2011-11-22 11:22 ` Wolfram Sang
2011-11-22 12:56 ` Rahul Bedarkar
2011-11-22 17:05 ` Marc Vertes
2011-11-22 17:30 ` Wolfram Sang
2011-11-22 18:09 ` Marc Vertes
2011-11-22 18:55 ` Marc Vertes
2011-11-23 12:10 ` Dmitry Artamonow
2011-11-23 14:12 ` Marc Vertes
2011-11-23 14:37 ` Mark Brown
2011-11-23 19:25 ` Dmitry Artamonow
2011-11-23 21:43 ` Wolfram Sang
2011-11-23 18:22 ` Harald Welte
2011-11-23 21:41 ` Wim Van Sebroeck
2011-11-24 19:22 ` Marc Vertes
2011-11-24 19:34 ` Wim Van Sebroeck
2011-11-25 20:02 ` Marc Vertes
2011-11-22 17:32 ` Mark Brown
2011-11-22 18:40 ` Wolfram Sang
2011-11-23 9:59 ` Marc Vertes [this message]
2011-11-23 10:49 ` Wolfram Sang
2011-11-23 11:43 ` Marc Vertes
2011-11-23 12:13 ` Wim Van Sebroeck
2011-11-23 12:20 ` Mark Brown
2011-11-23 12:40 ` Wim Van Sebroeck
2011-11-23 14:46 ` Marc Vertes
2011-11-23 21:43 ` Wim Van Sebroeck
2011-11-23 21:52 ` Wolfram Sang
2011-11-24 8:29 ` Wim Van Sebroeck
2011-11-23 21:46 ` Wim Van Sebroeck
2011-11-24 10:57 ` Marc Vertes
2011-11-24 13:42 ` Wim Van Sebroeck
2011-11-24 14:42 ` Marc Vertes
2011-11-24 15:48 ` Wim Van Sebroeck
2011-11-24 16:47 ` Marc Vertes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4eccc3f0.iApQ//mCzaN3UsrB%marc.vertes@sigfox.com \
--to=marc.vertes@sigfox.com \
--cc=Harald@vger.kernel.org \
--cc=HaraldWelte@viatech.com \
--cc=Sebroeck@vger.kernel.org \
--cc=Van@vger.kernel.org \
--cc=Welte@vger.kernel.org \
--cc=Wim@vger.kernel.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=w.sang@pengutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).