From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
broonie@kernel.org
Cc: alsa-devel@alsa-project.org, ckeepax@opensource.cirrus.com,
tiwai@suse.com, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, vkoul@kernel.org
Subject: Re: [PATCH 03/11] ASoC: q6asm: make commands specific to streams
Date: Wed, 8 Jul 2020 10:44:19 +0100 [thread overview]
Message-ID: <4eedae20-903f-77c6-c6e9-fbf3db209bcf@linaro.org> (raw)
In-Reply-To: <9ff595b4-1093-36c8-f27f-f097e24657a0@linux.intel.com>
Thanks Pierre for quick review,
On 07/07/2020 17:52, Pierre-Louis Bossart wrote:
>
>
>
>> @@ -184,8 +186,8 @@ static void event_handler(uint32_t opcode,
>> uint32_t token,
>> switch (opcode) {
>> case ASM_CLIENT_EVENT_CMD_RUN_DONE:
>> if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
>> - q6asm_write_async(prtd->audio_client,
>> - prtd->pcm_count, 0, 0, NO_TIMESTAMP);
>> + q6asm_write_async(prtd->audio_client, prtd->stream_id,
>> + prtd->pcm_count, 0, 0, 0);
>
> sound/soc/qcom/qdsp6/q6asm.h:#define NO_TIMESTAMP 0xFF00
>
> is the change on the previous line intentional?
May be not!
Plan is that the users of these apis will send flags directly instead of
boiler plating this!
This change should go as part of next patch("[PATCH 04/11] ASoC: q6asm:
use flags directly from asm-dai") which would make it much clear!
thanks,
srini
next prev parent reply other threads:[~2020-07-08 9:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 16:36 [PATCH 00/11] ASoC: qdsp6: add gapless compressed audio support Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 01/11] ASoC: q6asm: add command opcode to timeout error report Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 02/11] ASoC: q6asm: rename misleading session id variable Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 03/11] ASoC: q6asm: make commands specific to streams Srinivas Kandagatla
2020-07-07 16:52 ` Pierre-Louis Bossart
2020-07-08 9:44 ` Srinivas Kandagatla [this message]
2020-07-08 13:13 ` Mark Brown
2020-07-08 15:26 ` Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 04/11] ASoC: q6asm: use flags directly from asm-dai Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 05/11] ASoC: q6asm: add length to write command token Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 06/11] ASoC: q6asm: add support to remove intial and trailing silence Srinivas Kandagatla
2020-07-07 16:55 ` Pierre-Louis Bossart
2020-07-08 9:44 ` Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 07/11] ASoC: q6asm: add support to gapless flag in asm open Srinivas Kandagatla
2020-07-07 16:57 ` Pierre-Louis Bossart
2020-07-08 9:44 ` Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 08/11] ASoC: q6asm-dai: add next track metadata support Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 09/11] ASoC: qdsp6: use dev_err instead of pr_err Srinivas Kandagatla
2020-07-07 16:36 ` [PATCH 10/11] ASoC: qdsp6-dai: add gapless support Srinivas Kandagatla
2020-07-07 17:07 ` Pierre-Louis Bossart
2020-07-08 9:44 ` Srinivas Kandagatla
2020-07-08 13:32 ` Pierre-Louis Bossart
2020-07-08 13:42 ` Mark Brown
2020-07-08 15:23 ` Srinivas Kandagatla
2020-07-08 16:58 ` Pierre-Louis Bossart
2020-07-07 16:36 ` [PATCH 11/11] ASoC: q6asm-dai: add support to copy callback Srinivas Kandagatla
2020-07-08 13:32 ` [PATCH 00/11] ASoC: qdsp6: add gapless compressed audio support Mark Brown
2020-07-08 15:24 ` Srinivas Kandagatla
2020-07-08 16:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4eedae20-903f-77c6-c6e9-fbf3db209bcf@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).