From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751605AbdE3MrB (ORCPT ); Tue, 30 May 2017 08:47:01 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:38876 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbdE3MrA (ORCPT ); Tue, 30 May 2017 08:47:00 -0400 Subject: Re: [PATCH 1/7] powerpc/mm: rename map_page() to map_kernel_page() on PPC32 To: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Scott Wood , Balbir Singh Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <83aadb3163da87ec017ca4a61afcc29520a27eff.1496070452.git.christophe.leroy@c-s.fr> <8760gi62jw.fsf@concordia.ellerman.id.au> From: Christophe LEROY Message-ID: <4ef6cdbc-9a35-537d-d0f4-2d7cbb67ed59@c-s.fr> Date: Tue, 30 May 2017 14:46:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <8760gi62jw.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 30/05/2017 à 12:50, Michael Ellerman a écrit : > Christophe Leroy writes: > > ... > > Please tell me why. Because of patch https://patchwork.ozlabs.org/patch/766777/ which modifies patch_instruction() to use an alternative mapping. Compilation fails on PPC32 because map_kernel_page() only exists on PPC64. However we have map_page() which does the same on PPC32, hence the renaming. > > You also moved the declaration from mmu_decl.h to book3s/32/pgtable.h, > but didn't update any includes, presumably we're confident everything > gets pgtable.h somehow? Yes I did that so that lib/code_patching.c sees it. All users of map_page() already include pgtable in a way or another. Christophe