From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Pravin Shedge <pravin.shedge4linux@gmail.com>,
Quentin Schulz <quentin.schulz@free-electrons.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions
Date: Mon, 19 Mar 2018 10:51:43 +0100 [thread overview]
Message-ID: <4f0c5eb0-e7c2-9c27-387a-e62b19f0578a@users.sourceforge.net> (raw)
In-Reply-To: <20180318101506.460f3967@archlinux>
>> The mutex was (and is still only) locked within case branches, isn't it?
>>
> You are correct, this does however reflect the issue with the resulting
> lack of balance here.
I suggest to reconsider affected software aspects a bit more.
> I saw the mutex was getting unlocked outside the local scope and so assumed
> that it was also take outside the local scope.
Assumptions and corresponding expectations might need further clarifications.
> That isn't true, so we have hurt readability.
Does your conclusion need any adjustment?
> I read it quickly and got the wrong idea which generally implies it is not
> as clear as we would like.
>
> Hence this change isn't going anywhere I'm afraid.
I imagine that more time will be needed then to get used to additional adjustments
of implementation details in these functions.
Regards,
Markus
next prev parent reply other threads:[~2018-03-19 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 15:15 [PATCH] iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions SF Markus Elfring
2018-03-17 19:54 ` Jonathan Cameron
2018-03-18 8:19 ` SF Markus Elfring
2018-03-18 10:15 ` Jonathan Cameron
2018-03-19 9:51 ` SF Markus Elfring [this message]
2018-03-24 9:08 ` SF Markus Elfring
2018-03-18 10:05 ` [PATCH] " Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f0c5eb0-e7c2-9c27-387a-e62b19f0578a@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=pravin.shedge4linux@gmail.com \
--cc=quentin.schulz@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).