From: Chanwoo Choi <cwchoi00@gmail.com>
To: Dong Aisheng <aisheng.dong@nxp.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: dongas86@gmail.com, kernel@pengutronix.de, shawnguo@kernel.org,
linux-imx@nxp.com, linux-kernel@vger.kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
cw00.choi@samsung.com, abel.vesa@nxp.com
Subject: Re: [PATCH V2 RESEND 4/4] PM / devfreq: imx8m-ddrc: remove imx8m_ddrc_get_dev_status
Date: Tue, 23 Mar 2021 23:56:45 +0900 [thread overview]
Message-ID: <4f0cb67c-7f68-580a-9fbe-43b02d74c8a0@gmail.com> (raw)
In-Reply-To: <1616484011-26702-5-git-send-email-aisheng.dong@nxp.com>
On 21. 3. 23. 오후 4:20, Dong Aisheng wrote:
> Current driver actually does not support simple ondemand governor
> as it's unable to provide device load information. So removing
> the unnecessary callback to avoid confusing.
> Right now the driver is using userspace governor by default.
>
> polling_ms was also dropped as it's not needed for non-ondemand
> governor.
>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> drivers/devfreq/imx8m-ddrc.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c
> index bc82d3653bff..ecb9375aa877 100644
> --- a/drivers/devfreq/imx8m-ddrc.c
> +++ b/drivers/devfreq/imx8m-ddrc.c
> @@ -280,18 +280,6 @@ static int imx8m_ddrc_get_cur_freq(struct device *dev, unsigned long *freq)
> return 0;
> }
>
> -static int imx8m_ddrc_get_dev_status(struct device *dev,
> - struct devfreq_dev_status *stat)
> -{
> - struct imx8m_ddrc *priv = dev_get_drvdata(dev);
> -
> - stat->busy_time = 0;
> - stat->total_time = 0;
> - stat->current_frequency = clk_get_rate(priv->dram_core);
> -
> - return 0;
> -}
> -
> static int imx8m_ddrc_init_freq_info(struct device *dev)
> {
> struct imx8m_ddrc *priv = dev_get_drvdata(dev);
> @@ -429,9 +417,7 @@ static int imx8m_ddrc_probe(struct platform_device *pdev)
> if (ret < 0)
> goto err;
>
> - priv->profile.polling_ms = 1000;
> priv->profile.target = imx8m_ddrc_target;
> - priv->profile.get_dev_status = imx8m_ddrc_get_dev_status;
> priv->profile.exit = imx8m_ddrc_exit;
> priv->profile.get_cur_freq = imx8m_ddrc_get_cur_freq;
> priv->profile.initial_freq = clk_get_rate(priv->dram_core);
>
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
prev parent reply other threads:[~2021-03-23 14:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 7:20 [PATCH V2 RESEND 0/4] PM / devfreq: a few small fixes and improvements Dong Aisheng
2021-03-23 7:20 ` [PATCH V2 RESEND 1/4] PM / devfreq: Use more accurate returned new_freq as resume_freq Dong Aisheng
2021-03-23 14:55 ` Chanwoo Choi
2021-03-23 7:20 ` [PATCH V2 RESEND 2/4] PM / devfreq: Remove the invalid description for get_target_freq Dong Aisheng
2021-03-23 14:56 ` Chanwoo Choi
2021-03-23 7:20 ` [PATCH V2 RESEND 3/4] PM / devfreq: bail out early if no freq changes in devfreq_set_target Dong Aisheng
2021-03-23 15:01 ` Chanwoo Choi
2021-05-19 6:51 ` Dong Aisheng
2021-03-23 7:20 ` [PATCH V2 RESEND 4/4] PM / devfreq: imx8m-ddrc: remove imx8m_ddrc_get_dev_status Dong Aisheng
2021-03-23 14:56 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f0cb67c-7f68-580a-9fbe-43b02d74c8a0@gmail.com \
--to=cwchoi00@gmail.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=cw00.choi@samsung.com \
--cc=dongas86@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).