From: Sagi Grimberg <sagi@grimberg.me>
To: Johannes Thumshirn <jthumshirn@suse.de>,
Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>
Cc: Hannes Reinecke <hare@suse.de>,
maxg@mellanox.com,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 5/8] nvme: get list of namespace descriptors
Date: Sun, 4 Jun 2017 18:06:02 +0300 [thread overview]
Message-ID: <4f10963d-2d05-dfa1-1c4f-99b0202f38db@grimberg.me> (raw)
In-Reply-To: <20170604103649.22130-6-jthumshirn@suse.de>
On 04/06/17 13:36, Johannes Thumshirn wrote:
> If a target identifies itself as NVMe 1.3 compliant, try to get the
> list of Namespace Identification Descriptors and populate the UUID,
> NGUID and EUI64 fileds in the NVMe namespace structure with these
> values.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
> drivers/nvme/host/core.c | 87 ++++++++++++++++++++++++++++++++++++++++++++++++
> drivers/nvme/host/nvme.h | 1 +
> 2 files changed, 88 insertions(+)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 7b254be16887..37047841da0e 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -643,6 +643,85 @@ int nvme_identify_ctrl(struct nvme_ctrl *dev, struct nvme_id_ctrl **id)
> return error;
> }
>
> +static void nvme_parse_ns_descs(struct nvme_ns *ns, void *data)
> +{
> + int pos;
> + int len;
> +
> + for (pos = 0; pos < NVME_IDENTIFY_DATA_SIZE; pos += len) {
> + struct nvme_ns_identifier_hdr *cur = data + pos;
> +
> + if (cur->nidl == 0)
> + break;
> +
> + switch (cur->nidt) {
> + case NVME_NIDT_EUI64:
> + if (cur->nidl != NVME_NIDT_EUI64_LEN) {
> + dev_warn(ns->ctrl->dev,
> + "Target returned bogus length: %d for NVME_NIDT_EUI64\n",
> + cur->nidl);
Hmm, "target" is not a spec'd entity in NVMe AFAIR, and we try to avoid
using this language in the host too, lets call it "ctrl".
next prev parent reply other threads:[~2017-06-04 15:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 10:36 [PATCH v4 0/8] Implement NVMe Namespace Descriptor Identification Johannes Thumshirn
2017-06-04 10:36 ` [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures Johannes Thumshirn
2017-06-04 14:43 ` Sagi Grimberg
2017-06-04 14:59 ` Sagi Grimberg
2017-06-05 5:33 ` Christoph Hellwig
2017-06-06 6:23 ` Hannes Reinecke
2017-06-04 10:36 ` [PATCH v4 2/8] nvme: rename uuid to nguid in nvme_ns Johannes Thumshirn
2017-06-04 14:43 ` Sagi Grimberg
2017-06-04 10:36 ` [PATCH v4 3/8] nvmet: implement namespace identify descriptor list Johannes Thumshirn
2017-06-04 15:00 ` Sagi Grimberg
2017-06-05 5:35 ` Christoph Hellwig
2017-06-06 12:04 ` Johannes Thumshirn
2017-06-06 6:23 ` Hannes Reinecke
2017-06-04 10:36 ` [PATCH v4 4/8] nvmet: add uuid field to nvme_ns and populate via configfs Johannes Thumshirn
2017-06-04 11:46 ` Max Gurtovoy
2017-06-04 15:01 ` Sagi Grimberg
2017-06-06 6:24 ` Hannes Reinecke
2017-06-04 10:36 ` [PATCH v4 5/8] nvme: get list of namespace descriptors Johannes Thumshirn
2017-06-04 15:06 ` Sagi Grimberg [this message]
2017-06-05 5:38 ` Christoph Hellwig
2017-06-06 7:15 ` Sagi Grimberg
2017-06-06 6:24 ` Hannes Reinecke
2017-06-04 10:36 ` [PATCH v4 6/8] nvme: provide UUID value to userspace Johannes Thumshirn
2017-06-04 15:06 ` Sagi Grimberg
2017-06-04 10:36 ` [PATCH v4 7/8] nvmet: allow overriding the NVMe VS via configfs Johannes Thumshirn
2017-06-04 15:08 ` Sagi Grimberg
2017-06-05 5:45 ` Christoph Hellwig
2017-06-06 6:25 ` Hannes Reinecke
2017-06-04 10:36 ` [PATCH v4 8/8] nvmet: use NVME_IDENTIFY_DATA_SIZE Johannes Thumshirn
2017-06-04 14:06 ` Max Gurtovoy
2017-06-04 15:09 ` Sagi Grimberg
2017-06-05 8:37 ` Christoph Hellwig
2017-06-06 6:26 ` Hannes Reinecke
2017-06-05 5:32 ` [PATCH v4 0/8] Implement NVMe Namespace Descriptor Identification Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f10963d-2d05-dfa1-1c4f-99b0202f38db@grimberg.me \
--to=sagi@grimberg.me \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).