* [PATCH] add missing "source" line for firmware subdirectory in drivers/Kconfig
@ 2017-11-28 7:12 Heiner Kallweit
2017-11-28 17:09 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Heiner Kallweit @ 2017-11-28 7:12 UTC (permalink / raw)
To: Sudeep Holla; +Cc: Linux Kernel Mailing List
I have a little bit of a hard time to find the right addressee for
this patch because there is no maintainer entry for drivers/firmware.
Can you apply the following through your tree?
Add missing entry for firmware subdirectory in drivers/Kconfig.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/Kconfig b/drivers/Kconfig
index 152744c5e..a506867d9 100644
--- a/drivers/Kconfig
+++ b/drivers/Kconfig
@@ -39,6 +39,8 @@ source "drivers/message/fusion/Kconfig"
source "drivers/firewire/Kconfig"
+source "drivers/firmware/Kconfig"
+
source "drivers/macintosh/Kconfig"
source "drivers/net/Kconfig"
--
2.15.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] add missing "source" line for firmware subdirectory in drivers/Kconfig
2017-11-28 7:12 [PATCH] add missing "source" line for firmware subdirectory in drivers/Kconfig Heiner Kallweit
@ 2017-11-28 17:09 ` Randy Dunlap
2017-11-28 19:36 ` Heiner Kallweit
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2017-11-28 17:09 UTC (permalink / raw)
To: Heiner Kallweit, Sudeep Holla; +Cc: Linux Kernel Mailing List
On 11/27/2017 11:12 PM, Heiner Kallweit wrote:
> I have a little bit of a hard time to find the right addressee for
> this patch because there is no maintainer entry for drivers/firmware.
> Can you apply the following through your tree?
>
> Add missing entry for firmware subdirectory in drivers/Kconfig.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>]
Hi,
Why do you need this patch? You should explain that in the (missing)
patch description.
I suppose that it could be done like this, but currently any $ARCH that
wants to use drivers/firmware/Kconfig does so in the arch/$ARCH/Kconfig file:
arch> grep firmware/Kconfig */Kconfig
arm/Kconfig:source "arch/arm/firmware/Kconfig"
arm/Kconfig:source "drivers/firmware/Kconfig"
arm64/Kconfig:source "drivers/firmware/Kconfig"
blackfin/Kconfig:source "drivers/firmware/Kconfig"
ia64/Kconfig:source "drivers/firmware/Kconfig"
mips/Kconfig:source "drivers/firmware/Kconfig"
x86/Kconfig:source "drivers/firmware/Kconfig"
so all of these would need to be removed.
> ---
> drivers/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/Kconfig b/drivers/Kconfig
> index 152744c5e..a506867d9 100644
> --- a/drivers/Kconfig
> +++ b/drivers/Kconfig
> @@ -39,6 +39,8 @@ source "drivers/message/fusion/Kconfig"
>
> source "drivers/firewire/Kconfig"
>
> +source "drivers/firmware/Kconfig"
> +
> source "drivers/macintosh/Kconfig"
>
> source "drivers/net/Kconfig"
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] add missing "source" line for firmware subdirectory in drivers/Kconfig
2017-11-28 17:09 ` Randy Dunlap
@ 2017-11-28 19:36 ` Heiner Kallweit
0 siblings, 0 replies; 3+ messages in thread
From: Heiner Kallweit @ 2017-11-28 19:36 UTC (permalink / raw)
To: Randy Dunlap, Sudeep Holla; +Cc: Linux Kernel Mailing List
Am 28.11.2017 um 18:09 schrieb Randy Dunlap:
> On 11/27/2017 11:12 PM, Heiner Kallweit wrote:
>> I have a little bit of a hard time to find the right addressee for
>> this patch because there is no maintainer entry for drivers/firmware.
>> Can you apply the following through your tree?
>>
>> Add missing entry for firmware subdirectory in drivers/Kconfig.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>]
>
> Hi,
> Why do you need this patch? You should explain that in the (missing)
> patch description.
>
> I suppose that it could be done like this, but currently any $ARCH that
> wants to use drivers/firmware/Kconfig does so in the arch/$ARCH/Kconfig file:
>
> arch> grep firmware/Kconfig */Kconfig
> arm/Kconfig:source "arch/arm/firmware/Kconfig"
> arm/Kconfig:source "drivers/firmware/Kconfig"
> arm64/Kconfig:source "drivers/firmware/Kconfig"
> blackfin/Kconfig:source "drivers/firmware/Kconfig"
> ia64/Kconfig:source "drivers/firmware/Kconfig"
> mips/Kconfig:source "drivers/firmware/Kconfig"
> x86/Kconfig:source "drivers/firmware/Kconfig"
>
> so all of these would need to be removed.
>
Thanks for the hints!
Reason is that I received an error report for a patch, and this error report
was about a problem with compiling scpi clk driver with COMPILE_TEST on a
xtensa platform. And the scpi clk driver depends on the scpi driver under
drivers/firmware.
Based on what you explained and after fixing the dependency for the scpi
clk driver the proposed patch shouldn't be needed any longer.
Thanks, Heiner
>> ---
>> drivers/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/Kconfig b/drivers/Kconfig
>> index 152744c5e..a506867d9 100644
>> --- a/drivers/Kconfig
>> +++ b/drivers/Kconfig
>> @@ -39,6 +39,8 @@ source "drivers/message/fusion/Kconfig"
>>
>> source "drivers/firewire/Kconfig"
>>
>> +source "drivers/firmware/Kconfig"
>> +
>> source "drivers/macintosh/Kconfig"
>>
>> source "drivers/net/Kconfig"
>>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-28 19:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-28 7:12 [PATCH] add missing "source" line for firmware subdirectory in drivers/Kconfig Heiner Kallweit
2017-11-28 17:09 ` Randy Dunlap
2017-11-28 19:36 ` Heiner Kallweit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).